Include hostcommon sources in hostfxr static library #75858

rseanhall · 2022-09-19T20:24:16Z

The hostfxr static library can't be used without this.

ghost · 2022-09-19T20:24:28Z

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

The hostfxr static library can't be used without this.

Author:	rseanhall
Assignees:	-
Labels:	`area-Host`
Milestone:	-

rseanhall · 2022-09-19T20:31:10Z

I don't know if there's anything that can be done with the build process, but it was harder than I would like to build this change. All I wanted was to build the Microsoft.NETCore.DotNetAppHost packages so I tried to run build -subset host. This failed with:

  InjectResource -> C:\src\dotnet-runtime\artifacts\bin\coreclr\windows.x64.Debug\InjectResource\InjectResource.dll
C:\src\dotnet-runtime\src\native\corehost\corehost.proj(48,5): error MSB3030: Could not copy the file "C:\src\dotnet-ru
ntime\artifacts\bin\coreclr\windows.x64.Debug\/corehost/singlefilehost.exe" because it was not found.

I ended up copying a dummy singlefilehost.exe into the right place and disabling the PrepareSingleFileHostWithEmbeddedDac target because I didn't want to build anything else.

jkotas · 2022-09-19T22:25:32Z

Microsoft.NETCore.DotNetAppHost package is bundled into the SDK and installed under c:\Program Files\dotnet\packs\Microsoft.NETCore.App.Host.win-x64. We are adding more stuff to it for niche scenarios that do not look like a good fit for default .NET SDK download.

Do we need to rethink the package structure?

rseanhall · 2022-09-20T14:10:11Z

@jkotas That is not what I see. I added libhostfxr.lib to the package in .NET 6 and I don't see that file in the path you provided for .NET 6.0.8 or .NET 7 RC1.

Sometime later, the code was refactored and parts of hostfxr were moved into the hostcommon static lib. This is just adding the missing code. I would be fine with a custom host package, but it seems like changing the distribution of these assets seems to be low priority for everyone.

src/native/corehost/fxr/standalone/CMakeLists.txt

jkotas · 2022-09-20T15:32:48Z

@jkotas That is not what I see. I added libhostfxr.lib to the package in .NET 6 and I don't see that file in the path you provided for .NET 6.0.8 or .NET 7 RC1.

Ok, I got confused by the two very similar packages with overlapping content: Microsoft.NETCore.App.Host (bundled into SDK) and Microsoft.NETCore.DotNetAppHost (not bundled into SDK). This change is only adding this to Microsoft.NETCore.DotNetAppHost so my concern about SDK download size is moot.

@vitek-karas For my education: Why do have so much stuff in the package that is bundled into the SDK - how are we deciding what should go into each of these two package?

jkotas · 2022-09-20T17:08:48Z

BTW: A solution that was implemented in #72896 for similar problem was to ship the relevant C/C++ sources in the nuget package. I expect we will prefer shipping C/C++ sources for these situations going forward. It avoids the problems with fragility of C/C++ .libs and compiler settings.

rseanhall · 2022-10-11T01:02:32Z

runtime (Build Build OSX x64 release NativeAOT) failure

Building tests via "/Users/runner/work/1/s/eng/common/msbuild.sh"  --warnAsError false /Users/runner/work/1/s/src/tests/build.proj /t:TestBuild /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=OSX /nodeReuse:false    /maxcpucount "/flp:Verbosity=normal;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.log" "/flp1:WarningsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.wrn" "/flp2:ErrorsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.err" "/bl:/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.binlog" /p:NUMBER_OF_PROCESSORS=4
/Users/runner/work/1/s/.dotnet/sdk/7.0.100-rc.1.22431.12/MSBuild.dll /nologo -maxcpucount /m /maxcpucount -verbosity:m /v:minimal /bl:/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.binlog /clp:Summary /flp1:WarningsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.wrn /flp2:ErrorsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.err /flp:Verbosity=normal;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.log /nr:true /nodeReuse:false /p:TreatWarningsAsErrors=false /p:ContinuousIntegrationBuild=false /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=OSX /p:NUMBER_OF_PROCESSORS=4 /t:TestBuild /Users/runner/work/1/s/src/tests/build.proj
  [17:10:30.75] Restoring all packages...
    Determining projects to restore...
    Restored /Users/runner/work/1/s/src/tests/Common/test_dependencies_fs/test_dependencies.fsproj (in 30.52 sec).
    Determining projects to restore...
    Restored /Users/runner/work/1/s/src/tests/Common/test_dependencies/test_dependencies.csproj (in 10.14 sec).
/Users/runner/work/1/s/src/tests/build.proj(437,5): error MSB3073: The command ""/Users/runner/work/1/s/.dotnet/dotnet" restore -r osx-x64 Common/test_dependencies/test_dependencies.csproj  /p:SetTFMForRestore=true /p:TargetOS=OSX /p:TargetArchitecture=x64 /p:Configuration=Release /p:CrossBuild=" exited with code 1.

Build FAILED.

This is #74328?

runtime (Build mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) failure

2022-10-10T17:37:44.1809505Z /__w/1/s/src/mono/msbuild/aot-compile.proj(19,9): error MSB3073: The command "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/xunit.execution.dotnet.dll" exited with code 255.
2022-10-10T17:37:44.1810593Z BEGIN : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]
2022-10-10T17:37:44.1811488Z END : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]

I don't think this was caused by my change. If it were, I would expect the arm64 build to have failed as well.

jkotas

LGTM

jkotas · 2022-10-11T02:03:17Z

@vitek-karas @elinor-fung Any additional feedback?

elinor-fung

Thanks, @rseanhall!

elinor-fung · 2022-10-11T05:36:52Z

runtime (Build mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) failure

2022-10-10T17:37:44.1809505Z /__w/1/s/src/mono/msbuild/aot-compile.proj(19,9): error MSB3073: The command "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/xunit.execution.dotnet.dll" exited with code 255.
2022-10-10T17:37:44.1810593Z BEGIN : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]
2022-10-10T17:37:44.1811488Z END : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]

I don't think this was caused by my change. If it were, I would expect the arm64 build to have failed as well.

I think this is #72114.

dotnet-issue-labeler bot added the area-Host label Sep 19, 2022

ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 19, 2022

vitek-karas requested review from elinor-fung and VSadov September 19, 2022 20:57

jkotas reviewed Sep 20, 2022

View reviewed changes

src/native/corehost/fxr/standalone/CMakeLists.txt Outdated Show resolved Hide resolved

vitek-karas assigned elinor-fung Sep 26, 2022

Build static hostfxr library such that it doesn't require hostcommon.

d212e5d

rseanhall force-pushed the static-hostcommon branch from 6c86728 to d212e5d Compare October 10, 2022 16:21

rseanhall changed the title ~~Publish hostcommon static library~~ Include hostcommon sources in hostfxr static library Oct 10, 2022

build-analysis bot mentioned this pull request Oct 10, 2022

Tracking Nuget 429s dotnet/arcade#10885

Closed

2 tasks

jkotas approved these changes Oct 11, 2022

View reviewed changes

elinor-fung approved these changes Oct 11, 2022

View reviewed changes

elinor-fung mentioned this pull request Oct 11, 2022

mono minijit runtime tests failing with coreclr_initialize failed - Error: 0x80004005 #72114

Closed

elinor-fung merged commit 7c4bd4f into dotnet:main Oct 13, 2022

ghost locked as resolved and limited conversation to collaborators Nov 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include hostcommon sources in hostfxr static library #75858

Include hostcommon sources in hostfxr static library #75858

rseanhall commented Sep 19, 2022

ghost commented Sep 19, 2022

rseanhall commented Sep 19, 2022

jkotas commented Sep 19, 2022

rseanhall commented Sep 20, 2022

jkotas commented Sep 20, 2022

jkotas commented Sep 20, 2022

rseanhall commented Oct 11, 2022

jkotas left a comment

jkotas commented Oct 11, 2022

elinor-fung left a comment

elinor-fung commented Oct 11, 2022

Include hostcommon sources in hostfxr static library #75858

Include hostcommon sources in hostfxr static library #75858

Conversation

rseanhall commented Sep 19, 2022

ghost commented Sep 19, 2022

rseanhall commented Sep 19, 2022

jkotas commented Sep 19, 2022

rseanhall commented Sep 20, 2022

jkotas commented Sep 20, 2022

jkotas commented Sep 20, 2022

rseanhall commented Oct 11, 2022

jkotas left a comment

Choose a reason for hiding this comment

jkotas commented Oct 11, 2022

elinor-fung left a comment

Choose a reason for hiding this comment

elinor-fung commented Oct 11, 2022