Fix critical finalization test #75952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorBo
approved these changes
Sep 21, 2022
VSadov
reviewed
Sep 21, 2022
|
@AntonLapounov looks like it's still failing? e.g. in #75573 and other PRs ^ |
|
@radical This PR changed runtime tests; but the mono runtime tests CI lanes weren't triggered in this PR. Could you please check? |
|
Still failing for me too... #75992 (x86 windows). |
|
I opened #76041 for the new intermittent failure. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test assumed that all allocated
PandQobjects are collected during the same GC pass (Q.first_p_count == P.count), which may not be the case under GC stress. The fix is to unroot all allocated objects at the same time. I also fixed indentation, improved naming, and moved the test to the existingfinalizationdirectory.Fixes #75782.