Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark the port as implicit for empty values in Cookie #76143

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Mark the port as implicit for empty values in Cookie #76143

merged 3 commits into from
Oct 13, 2022

Conversation

dsisco11
Copy link
Contributor

@dsisco11 dsisco11 commented Sep 24, 2022 •
edited by karelz
Loading

Fixes #70227

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 24, 2022
@ghost
Copy link

ghost commented Sep 24, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: dsisco11
Assignees: -
Labels:

area-System.Net, community-contribution
Milestone: -

@dnfadmin
Copy link

dnfadmin commented Sep 25, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

@karelz karelz requested a review from MihaZupan September 29, 2022 15:24
@MihaZupan MihaZupan changed the title [Bug] Fix issue #70227 Mark the port as implicit for empty values in Cookie Oct 13, 2022
MihaZupan
MihaZupan approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.
Judging by #70227 (comment), Anton agrees with this as well.

@MihaZupan MihaZupan merged commit a41ac2c into dotnet:main Oct 13, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 12, 2022
@karelz karelz added this to the 8.0.0 milestone Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MihaZupan MihaZupan MihaZupan approved these changes

Assignees
No one assigned
Labels
area-System.Net community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Cookies lose implicit port after having port property set to empty string.
4 participants
@dsisco11 @dnfadmin @MihaZupan @karelz