Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoongArch64] Fix the assert error for genSetRegToIcon() #76164

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

shushanhf
Copy link
Contributor

This PR is part of the issue #69705 to amend the LA's port.

Fix the assert error for genSetRegToIcon() called by genSetRegToIcon().

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 26, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 26, 2022
@ghost
Copy link

ghost commented Sep 26, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR is part of the issue #69705 to amend the LA's port.

Fix the assert error for genSetRegToIcon() called by genSetRegToIcon().

Author: shushanhf
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@shushanhf
Copy link
Contributor Author

Hi, @jakobbotsch
Could you review this PR ?
thanks

@JulieLeeMSFT
Copy link
Member

cc @kunalspathak.

@JulieLeeMSFT JulieLeeMSFT added this to the 8.0.0 milestone Sep 26, 2022
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak kunalspathak merged commit 1f688ed into dotnet:main Sep 27, 2022
@shushanhf shushanhf deleted the LA_regConst branch September 28, 2022 00:48
@ghost ghost locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-loongarch64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants