Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Templates nits #76182

Merged
merged 6 commits into from
Sep 29, 2022
Merged

[wasm] Templates nits #76182

merged 6 commits into from
Sep 29, 2022

Conversation

maraf
Copy link
Member

@maraf maraf commented Sep 26, 2022

  • Add template descriptions.
  • Unify string quotes.

Closes #75771 #75741

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono labels Sep 26, 2022
@maraf maraf added this to the 8.0.0 milestone Sep 26, 2022
@maraf maraf self-assigned this Sep 26, 2022
@ghost
Copy link

ghost commented Sep 26, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Add template descriptions.
  • Unify string quotes.

Closes #75771 #75741

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono
Milestone: 8.0.0

@lewing lewing requested a review from radical September 26, 2022 16:02
@radical
Copy link
Member

radical commented Sep 26, 2022

WBT test failures

@maraf maraf marked this pull request as ready for review September 27, 2022 08:24
@maraf maraf merged commit da9b348 into dotnet:main Sep 29, 2022
@maraf maraf deleted the WasmTemplatesNits branch September 29, 2022 07:42
@radical
Copy link
Member

radical commented Sep 29, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3150984190

@github-actions github-actions bot mentioned this pull request Sep 29, 2022
Merged
@pavelsavara pavelsavara mentioned this pull request Sep 30, 2022
Open
3 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical left review comments

@pavelsavara pavelsavara pavelsavara approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Update experimental WebAssembly templates to use consistent string quotes in JS
3 participants
@maraf @radical @pavelsavara