Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make KeysCollection.Contains methods public. #76319

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Sep 28, 2022

Fix #75936.

No testing added on the assumption that functional testing on the interface implementation is sufficient. Please let me know if separate testing for the newly exposed APIs is required.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned eiriktsarpalis Sep 28, 2022
@eiriktsarpalis eiriktsarpalis added this to the 8.0.0 milestone Sep 28, 2022
@ghost
Copy link

ghost commented Sep 28, 2022

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #75936.

No testing adding on the assumption that functional testing on the interface implementation is sufficient. Please let me know if separate testing for the newly exposed APIs is required.

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Collections, new-api-needs-documentation

Milestone: -

@campersau
Copy link
Contributor

Should the commit message / title be Make KeysCollection.Contains methods public. instead of ContainsKey?

@eiriktsarpalis eiriktsarpalis changed the title Make KeysCollection.ContainsKey methods public. Make KeysCollection.Contains methods public. Sep 29, 2022
@eiriktsarpalis
Copy link
Member Author

It should -- I've updated the PR title so that it shows up correctly in the final commit. Thanks.

@stephentoub stephentoub merged commit ed9afa8 into dotnet:main Sep 29, 2022
@eiriktsarpalis eiriktsarpalis deleted the keyscollection-containskey branch September 29, 2022 14:07
@ghost ghost locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Dictionary<TKey, TValue>.KeysCollection.Contains
3 participants