Move the [With|Get]Element(SIMD) folding to local morph

[SingleAccretion]

This moves the special machinery for morphing local indirs off of SIMDs to local morph, deleting one of the last two cases where SelectLocalIndirTransform will return IndirTransform::None (we're getting close!).

Diffs - improvements; all regressions I checked were due to copy propagation making something worse downstream or us allocating callee saves to enregister a-now-DNER-less local.

(This includes the x86 regressions too, of which most are PerfScore improvements)

There is also a nice TP win.

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This transformation is not really profitable when not optimizing.

Note: currently this will produce some regressions, it needs the continuation of #76155.

Author:	SingleAccretion
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[ghost]

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

[SingleAccretion]

@dotnet/jit-contrib

[BruceForstall]

@SingleAccretion Needs conflict resolution

[SingleAccretion]

Needs conflict resolution

Done.

[SingleAccretion]

Build CoreCLR Product Build Linux_musl arm64 checked failure does not look related:

2022-11-24T17:24:35.5115315Z Building tests via "/__w/1/s/eng/common/msbuild.sh"  --warnAsError false /__w/1/s/src/tests/build.proj /t:TestBuild /p:TargetArchitecture=arm64 /p:Configuration=Checked /p:TargetOS=Linux /nodeReuse:false    /maxcpucount "/flp:Verbosity=normal;LogFile=/__w/1/s/artifacts/log/TestBuild.Linux.arm64.Checked.log" "/flp1:WarningsOnly;LogFile=/__w/1/s/artifacts/log/TestBuild.Linux.arm64.Checked.wrn" "/flp2:ErrorsOnly;LogFile=/__w/1/s/artifacts/log/TestBuild.Linux.arm64.Checked.err" "/bl:/__w/1/s/artifacts/log/TestBuild.Linux.arm64.Checked.binlog" /p:NUMBER_OF_PROCESSORS=4 /p:CrossBuild=true
2022-11-24T17:24:35.8072069Z /__w/1/s/.dotnet/sdk/7.0.100-rc.1.22431.12/MSBuild.dll /nologo -maxcpucount /m /maxcpucount -verbosity:m /v:minimal /bl:/__w/1/s/artifacts/log/TestBuild.Linux.arm64.Checked.binlog /clp:Summary /flp1:WarningsOnly;LogFile=/__w/1/s/artifacts/log/TestBuild.Linux.arm64.Checked.wrn /flp2:ErrorsOnly;LogFile=/__w/1/s/artifacts/log/TestBuild.Linux.arm64.Checked.err /flp:Verbosity=normal;LogFile=/__w/1/s/artifacts/log/TestBuild.Linux.arm64.Checked.log /nr:true /nodeReuse:false /p:TreatWarningsAsErrors=false /p:ContinuousIntegrationBuild=false /p:TargetArchitecture=arm64 /p:Configuration=Checked /p:TargetOS=Linux /p:NUMBER_OF_PROCESSORS=4 /p:CrossBuild=true /t:TestBuild /__w/1/s/src/tests/build.proj
2022-11-24T17:24:37.1652557Z   [17:24:37.16] Restoring all packages...
2022-11-24T17:24:38.7045729Z     Determining projects to restore...
2022-11-24T17:24:42.2984449Z     Restored /__w/1/s/src/tests/Common/test_dependencies_fs/test_dependencies.fsproj (in 2.85 sec).
2022-11-24T17:24:43.1905807Z     Determining projects to restore...
2022-11-24T17:24:45.4645760Z     Restored /__w/1/s/src/tests/Common/test_dependencies/test_dependencies.csproj (in 1.36 sec).
2022-11-24T17:24:46.1267240Z     Determining projects to restore...
2022-11-24T17:24:55.9649368Z     Restored /__w/1/s/src/tests/Common/CoreCLRTestLibrary/CoreCLRTestLibrary.csproj (in 8.97 sec).
2022-11-24T17:24:56.6697005Z     Determining projects to restore...
2022-11-24T17:25:00.5066972Z     Restored /__w/1/s/src/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.csproj (in 3.08 sec).
2022-11-24T17:25:01.1980038Z     Determining projects to restore...
2022-11-24T17:25:02.2152827Z     Restored /__w/1/s/src/tests/Common/XUnitWrapperLibrary/XUnitWrapperLibrary.csproj (in 181 ms).
2022-11-24T17:25:02.8633918Z     Determining projects to restore...
2022-11-24T17:25:05.0584527Z     Restored /__w/1/s/src/tests/Common/XHarnessRunnerLibrary/XHarnessRunnerLibrary.csproj (in 1.26 sec).
2022-11-24T17:25:05.0586498Z     1 of 2 projects are up-to-date for restore.
2022-11-24T17:25:05.0676523Z /__w/1/s/src/tests/build.proj(438,5): error MSB3073: The command ""/__w/1/s/.dotnet/dotnet" restore -r linux-musl-arm64 Common/XHarnessRunnerLibrary/XHarnessRunnerLibrary.csproj  /p:SetTFMForRestore=true /p:TargetOS=Linux /p:TargetArchitecture=arm64 /p:Configuration=Checked /p:CrossBuild=true" exited with code 1.
2022-11-24T17:25:05.0790364Z 
2022-11-24T17:25:05.0791504Z Build FAILED.
2022-11-24T17:25:05.0791651Z 
2022-11-24T17:25:05.0793334Z /__w/1/s/src/tests/build.proj(438,5): error MSB3073: The command ""/__w/1/s/.dotnet/dotnet" restore -r linux-musl-arm64 Common/XHarnessRunnerLibrary/XHarnessRunnerLibrary.csproj  /p:SetTFMForRestore=true /p:TargetOS=Linux /p:TargetArchitecture=arm64 /p:Configuration=Checked /p:CrossBuild=true" exited with code 1.
2022-11-24T17:25:05.0799140Z     0 Warning(s)
2022-11-24T17:25:05.0799777Z     1 Error(s)

[jakobbotsch]

Thank you! Sorry for the slowness.