Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix native AOT with CryptoKit #76499

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented Oct 1, 2022

This attempts to resolve the build issue with the introduction of the Swift runtime and CryptoKit.

I'll admit I'm outside my expertise here. If necessary we can back out the pull request that introduced this if we cannot find a suitable fix in time.

Closes #76498

/cc @jkotas

@vcsjones
Copy link
Member Author

vcsjones commented Oct 1, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member

jkotas commented Oct 1, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas jkotas requested a review from filipnavara October 1, 2022 23:46
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for quick turnaround!

@jkotas jkotas merged commit fb5f07f into dotnet:main Oct 2, 2022
@vcsjones vcsjones deleted the cryptokit-native-aot branch October 2, 2022 08:24
@ghost ghost locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NativeAOT] System.Security.Tests failing on macOS with link errors
3 participants