[Android] Fix NetworkInterface.GetAllNetworkInterfaces on API 21-23 #76541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger Issue DetailsThis is a follow-up to #76370 The /cc @akoeplinger
|
akoeplinger
approved these changes
Oct 3, 2022
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Failing tests are unrelated |
simonrozsival
added a commit
to simonrozsival/runtime
that referenced
this pull request
Oct 3, 2022
…otnet#76541) * Bring back pal_ifaddrs * Update the header file
carlossanlop
pushed a commit
that referenced
this pull request
Oct 5, 2022
…erfaces (#76565) * [Android] Fix NetworkInterface.GetAllNetworkInterfaces (#76370) * Revert "[Android] Port getifaddrs implementation from Xamarin.Android (#71943)" This reverts commit 1de4a5c. * Fix allocating memory block for interfaces and addresses on recent Android SDKs * Detect loopback interface on Android * Add comment with explanation * Simplify the changes to be closer to the original code * Fix build * Fix typos Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> * Improve comment * Indent using spaces instead of tabs * Remove check for ifaddrs.h * Add ANDROID_GETIFADDRS_WORKAROUND * Update comment Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> * [Android] Fix NetworkInterface.GetAllNetworkInterfaces on API 21-23 (#76541) * Bring back pal_ifaddrs * Update the header file Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
simonrozsival
added a commit
to simonrozsival/runtime
that referenced
this pull request
Oct 20, 2022
…otnet#76541) * Bring back pal_ifaddrs * Update the header file
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #76370
The
pal_ifaddrs.cfile was incorrectly removed in #76370. We need it to keep it as a fallback to support Android 5-6 (API 21-23)./cc @akoeplinger
Fixes #75809
Fixes #76493
Fixes dotnet/android#6973