Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit flushing to ProcessStartInfoTests #76610

Closed
wants to merge 1 commit into from
Closed

Add explicit flushing to ProcessStartInfoTests #76610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ public void TestEnvironmentOfChildProcess()
Process p = CreateProcess(() =>
{
Console.Write(string.Join(ItemSeparator, Environment.GetEnvironmentVariables().Cast<DictionaryEntry>().Select(e => Convert.ToBase64String(Encoding.UTF8.GetBytes(e.Key + "=" + e.Value)))));
Console.Out.Flush();
return RemoteExecutor.SuccessExitCode;
});
p.StartInfo.StandardOutputEncoding = Encoding.UTF8;
Expand Down Expand Up @@ -278,7 +279,6 @@ public void TestEnvironmentOfChildProcess()
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/76140", TestPlatforms.LinuxBionic)]
public void EnvironmentGetEnvironmentVariablesIsCaseSensitive()
{
var caseSensitiveEnvVars = new Dictionary<string, string>(StringComparer.Ordinal)
Expand All @@ -292,6 +292,7 @@ public void EnvironmentGetEnvironmentVariablesIsCaseSensitive()
() =>
{
Console.Write(string.Join(ItemSeparator, Environment.GetEnvironmentVariables().Cast<DictionaryEntry>().Select(e => Convert.ToBase64String(Encoding.UTF8.GetBytes(e.Key + "=" + e.Value)))));
Console.Out.Flush();
return RemoteExecutor.SuccessExitCode;
});

Expand All @@ -302,7 +303,6 @@ public void EnvironmentGetEnvironmentVariablesIsCaseSensitive()
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/76140", TestPlatforms.LinuxBionic)]
public void ProcessStartInfoEnvironmentDoesNotThrowForCaseSensitiveDuplicates()
{
var caseSensitiveEnvVars = new Dictionary<string, string>(StringComparer.Ordinal)
Expand All @@ -316,6 +316,7 @@ public void ProcessStartInfoEnvironmentDoesNotThrowForCaseSensitiveDuplicates()
() =>
{
Console.Write(string.Join(ItemSeparator, new ProcessStartInfo().Environment.Select(e => Convert.ToBase64String(Encoding.UTF8.GetBytes(e.Key + "=" + e.Value)))));
Console.Out.Flush();
return RemoteExecutor.SuccessExitCode;
});

Expand All @@ -327,7 +328,6 @@ public void ProcessStartInfoEnvironmentDoesNotThrowForCaseSensitiveDuplicates()
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/76140", TestPlatforms.LinuxBionic)]
public void ProcessStartInfoEnvironmentVariablesDoesNotThrowForCaseSensitiveDuplicates()
{
var caseSensitiveEnvVars = new Dictionary<string, string>(StringComparer.Ordinal)
Expand All @@ -341,6 +341,7 @@ public void ProcessStartInfoEnvironmentVariablesDoesNotThrowForCaseSensitiveDupl
() =>
{
Console.Write(string.Join(ItemSeparator, new ProcessStartInfo().EnvironmentVariables.Cast<DictionaryEntry>().Select(e => Convert.ToBase64String(Encoding.UTF8.GetBytes(e.Key + "=" + e.Value)))));
Console.Out.Flush();
return RemoteExecutor.SuccessExitCode;
});

Expand Down Expand Up @@ -373,7 +374,15 @@ private string[] ExecuteProcessAndReturnParsedOutput(Dictionary<string, string>
string output = p.StandardOutput.ReadToEnd();
Assert.True(p.WaitForExit(WaitInMS));

return output.Split(new[] { ItemSeparator }, StringSplitOptions.None).Select(s => Encoding.UTF8.GetString(Convert.FromBase64String(s))).ToArray();
try
{
return output.Split(new[] { ItemSeparator }, StringSplitOptions.None).Select(s => Encoding.UTF8.GetString(Convert.FromBase64String(s))).ToArray();
}
catch
{
Console.WriteLine($"Failed to parse output: {output}");
throw;
}
}

[Fact]
Expand Down