Don't scan bricks of frozen segments in verify_heap #76645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsAs it turns out it's not a product issue and just HeapVerify specific, the fix is written by @Maoni0 and @cshung, I'm filing a PR because I had a reproduction setup. For readers, https://cshung.github.io/posts/brick/ explains the "brick" concept.
|
Maoni0
reviewed
Oct 4, 2022
| #ifdef USE_REGIONS | ||
| assert (!heap_segment_read_only_p (seg)); |
There was a problem hiding this comment.
let's make this FATAL_GC_ERROR too.
Suggested change
| assert (!heap_segment_read_only_p (seg)); | |
| if (heap_segment_read_only_p (seg)) | |
| { | |
| dprintf (1, ("seg %Ix is ro! Shouldn't happen with regions", (size_t)seg)); | |
| FATAL_GC_ERROR(); | |
| } |
There was a problem hiding this comment.
ugh, no matter how many times I tried github refuses to apply this diff:
so I'm going to apply by hands and add you as co-authored
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75819
Fixes #75820
As it turns out it's not a product issue and just HeapVerify specific, the fix is written by @Maoni0 and @cshung, I'm filing a PR because I had a reproduction setup.
For readers, there is a good read https://cshung.github.io/posts/brick/ that explains the "brick table" concept.