Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct error messages for CoreCLR Win32 PAL uses in CoreLib #76768

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Correct error messages for CoreCLR Win32 PAL uses in CoreLib #76768

merged 1 commit into from
Oct 10, 2022

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Oct 7, 2022

Contributes to #76736

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned jkotas Oct 7, 2022
@ghost
Copy link

ghost commented Oct 7, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #76736

Author: jkotas
Assignees: jkotas
Labels:

area-System.Runtime.InteropServices
Milestone: -

@jkotas jkotas mentioned this pull request Oct 7, 2022
Closed
janvorli
janvorli approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@danmoseley
Copy link
Member

I guess we should backport?

@AaronRobinsonMSFT
Copy link
Member

I guess we should backport?

I think so, but perhaps we could wait to our first servicing window rather than GA?

@danmoseley
Copy link
Member

I'd say it's worth asking - there's been nothing deferred to 7.0.1 yet.

This was referenced Oct 8, 2022
Closed
Closed
@jkotas
Copy link
Member Author

jkotas commented Oct 8, 2022

we could wait to our first servicing window rather than GA?

It is for the servicing shiproom to decide. The basic rule is to take fixes sooner because of adoption (and thus blast radius of a potentially bad change) increases with time.

@jkotas jkotas closed this Oct 8, 2022
@jkotas jkotas reopened this Oct 8, 2022
@jkotas jkotas closed this Oct 9, 2022
@jkotas jkotas reopened this Oct 9, 2022
@jkotas jkotas closed this Oct 10, 2022
@jkotas jkotas reopened this Oct 10, 2022
@jkotas
Copy link
Member Author

jkotas commented Oct 10, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3219642530

@github-actions github-actions bot mentioned this pull request Oct 10, 2022
Merged
@jkotas jkotas mentioned this pull request Oct 10, 2022
Closed
@jkotas jkotas merged commit 6893524 into dotnet:main Oct 10, 2022
@jkotas jkotas deleted the pal-error-messages branch October 10, 2022 18:52
@build-analysis build-analysis bot mentioned this pull request Oct 10, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elinor-fung elinor-fung elinor-fung approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@janvorli janvorli janvorli approved these changes

@stephentoub stephentoub stephentoub approved these changes

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees

@jkotas jkotas

Labels
area-System.Runtime.InteropServices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jkotas @danmoseley @AaronRobinsonMSFT @jkoritzinsky @stephentoub @janvorli @elinor-fung