Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Clean near unmaintainable parallel logic 53593 #76949

Closed
wants to merge 16 commits into from
Closed

WIP: Clean near unmaintainable parallel logic 53593 #76949

wants to merge 16 commits into from

Conversation

tjwald
Copy link

@tjwald tjwald commented Oct 12, 2022 •
edited
Loading

PR for Issue: Issue

  • Merged ForWorker32 and ForWorker64 using Generic math
  • Extracted common functions from ForWorker and PartitionerForEachWorker

My Current Agenda:

  • Create Perf PR and submit
  • Split CreateForWorker Implementation according to loop body type
  • Merge ForWorker with PartitionerForEachWorker
  • Cleanup Merging code

tjwald added 14 commits October 8, 2022 20:01
@tjwald
moved ForWorker to use single function that dispatches into previous …
5e9ca4b 
…functions
@tjwald
extracted logging from seperate worker functions into generic function
df92a79
@tjwald
moved most of the code into generic function
9aa5479
@tjwald
merged create workers to use single implementation for both 32 and 64
c7d3e2a
@tjwald
* fixed false code comment
f465271 
* removed line breaks
@tjwald
created helper generic factory methods for better readability
2f5dc8d
@tjwald
cosmetic changes
4e41bb5
@tjwald
moved worker out and cleaned up fast paths for foreach imp
db42b15
@tjwald
extracted common functions from PartitionerForEachWorker and ForWorke…
7538707 
…r and their associated create worker methods
@tjwald
Extracted functions for readability in invoke
e2132f9
@tjwald
fixed tests
2bb045a
@tjwald
removed unnecessary function
095e14f
@tjwald
fixed tests for real!
af6e7d5
@tjwald
removed worker code for now
2dc1d87
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 12, 2022
@ghost
Copy link

ghost commented Oct 12, 2022

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Merged ForWorker32 and ForWorker64 using Generic math
  • Extracted common functions from ForWorker and ForEachPartitionWorker
Author: tjwald
Assignees: -
Labels:

area-System.Threading
Milestone: -

@dnfadmin
Copy link

dnfadmin commented Oct 12, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

@tjwald tjwald changed the title Clean near unmaintainable parallel logic 53593 WIP: Clean near unmaintainable parallel logic 53593 Oct 12, 2022
This was referenced Oct 12, 2022
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Oct 14, 2022
Closed
2 tasks
@ghost
Copy link

ghost commented Nov 7, 2022

Tagging subscribers to this area: @dotnet/area-system-threading-tasks
See info in area-owners.md if you want to be subscribed.

Issue Details

PR for Issue: Issue

  • Merged ForWorker32 and ForWorker64 using Generic math
  • Extracted common functions from ForWorker and PartitionerForEachWorker

My Current Agenda:

  • Create Perf PR and submit
  • Split CreateForWorker Implementation according to loop body type
  • Merge ForWorker with PartitionerForEachWorker
  • Cleanup Merging code
Author: tjwald
Assignees: -
Labels:

area-System.Threading.Tasks, community-contribution
Milestone: -

@tjwald tjwald mentioned this pull request Nov 7, 2022
Closed
@joperezr
Copy link
Member

joperezr commented Nov 9, 2022

cc: @stephentoub

@ericstj
Copy link
Member

ericstj commented Dec 15, 2022 •
edited
Loading

@dakersnar @tjwald -- I see you are active in #77993, so I will close this PR. If it's determined there that you prefer this smaller PR we can reopen at that time and get fresh build/test results.

@ericstj ericstj closed this Dec 15, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area-System.Threading.Tasks community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tjwald @dnfadmin @joperezr @ericstj @mangod9