Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] event pipe tweaks #76994

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Oct 13, 2022

The EP sample now downloads .nettrace when compiled with MonoDiagnosticsMock flag

To allow the app and the mock communicate

  • added postMessageToBrowser and addEventListenerFromBrowser to mock environment
  • exposed INTERNAL.diagnosticServerThread when built with MonoDiagnosticsMock
  • added processSend to MockScriptEngineImpl so that mock could process more than just first message

Other changes

  • fixed EP serializer of empty string vs null
  • make mime types and HTTP headers more configurable for all samples
  • move CSP policy header just into advanced sample (it prevents the EP socket to be open on another port)
  • added README
  • minor cleanup of async stuff

Contributes to #76316

…sticsMock (debug)

To allow the app and the mock communicate
- added postMessageToBrowser and addEventListenerFromBrowser to mock environment
- exposed INTERNAL.diagnosticServerThread when built with MonoDiagnosticsMock
- added processSend to MockScriptEngineImpl so that mock could process more than just first message

- fixed EP serializer of empty string vs null

- make mime types and http headers more configurable for all samples
- move CSP policy header just into advanced sample (it prevents the EP socket to be open on another port)
- added README
- minor cleanup of async stuff
@ghost
Copy link

ghost commented Oct 13, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • the EP sample will download .nettrace when compiled with MonoDiagnosticsMock flag

To allow the app and the mock communicate

  • added postMessageToBrowser and addEventListenerFromBrowser to mock environment

  • exposed INTERNAL.diagnosticServerThread when built with MonoDiagnosticsMock

  • added processSend to MockScriptEngineImpl so that mock could process more than just first message

  • fixed EP serializer of empty string vs null

  • make mime types and HTTP headers more configurable for all samples

  • move CSP policy header just into advanced sample (it prevents the EP socket to be open on another port)

  • added README

  • minor cleanup of async stuff

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone: 8.0.0

@pavelsavara pavelsavara marked this pull request as ready for review October 13, 2022 17:56
Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pavelsavara pavelsavara merged commit 54c4a4b into dotnet:main Oct 13, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2022
@pavelsavara pavelsavara deleted the wasm_event_pipe_tweaks branch September 2, 2024 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants