Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete fgMorphBlockOperand #77688

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Oct 31, 2022

No longer necessary as we don't need to compensate for invalid IR.

Diffs - a TP improvement, plus one small diff where we don't reduce OBJ(ADDR(LCL_VAR)) created by forward substitution, but it ends up being a bit better anyway.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 31, 2022
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 31, 2022
@ghost
Copy link

ghost commented Oct 31, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

No longer necessary as we don't need to compensate for invalid IR.

A minor TP improvement is expected, with no code diffs.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@SingleAccretion SingleAccretion force-pushed the MorphBlockOperand-Struct-Removal-Upstream branch from 26d3602 to 67cb0a9 Compare October 31, 2022 18:01
@SingleAccretion SingleAccretion force-pushed the MorphBlockOperand-Struct-Removal-Upstream branch from 67cb0a9 to 0dd1168 Compare October 31, 2022 21:17
@SingleAccretion
Copy link
Contributor Author

SingleAccretion commented Nov 1, 2022

Interesting OSX x64 (Libraries Test Run checked coreclr OSX x64 Debug) failure:

./RunTests.sh: line 168: 57924 Illegal instruction: 4  "$RUNTIME_PATH/dotnet" exec --runtimeconfig System.IO.FileSystem.Watcher.Tests.runtimeconfig.json --depsfile System.IO.FileSystem.Watcher.Tests.deps.json xunit.console.dll System.IO.FileSystem.Watcher.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing $RSP_FILE

Edit: machine was dci-mac-build-372.local.

Edit: I've run the CI a good number of times on this, and it did not reproduce. Will proceed with the change as-is for now.

@SingleAccretion SingleAccretion marked this pull request as ready for review November 3, 2022 19:26
@SingleAccretion SingleAccretion marked this pull request as draft November 3, 2022 19:26
@build-analysis build-analysis bot mentioned this pull request Nov 4, 2022
2 tasks
@SingleAccretion SingleAccretion force-pushed the MorphBlockOperand-Struct-Removal-Upstream branch from fc64545 to c87e737 Compare November 5, 2022 15:50
@SingleAccretion SingleAccretion force-pushed the MorphBlockOperand-Struct-Removal-Upstream branch from c87e737 to 0f11dc2 Compare November 10, 2022 17:23
@SingleAccretion SingleAccretion changed the title Remove fgMorphBlockOperand<struct> Remove fgMorphBlockOperand Nov 10, 2022
@SingleAccretion SingleAccretion force-pushed the MorphBlockOperand-Struct-Removal-Upstream branch from 0f11dc2 to c0e1eab Compare November 11, 2022 14:12
@SingleAccretion SingleAccretion changed the title Remove fgMorphBlockOperand Delete fgMorphBlockOperand Nov 11, 2022
@SingleAccretion SingleAccretion marked this pull request as ready for review November 11, 2022 17:06
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib

SPMI failures are due to missing Win-ARM64 collections.

@BruceForstall BruceForstall merged commit 43272d6 into dotnet:main Nov 12, 2022
@BruceForstall
Copy link
Member

SPMI failures are due to missing Win-ARM64 collections.

This was due to an undetermined failure to upload files. A recollect is in progress (takes ~6 hours). There is a usual one scheduled on Sundays.

@SingleAccretion SingleAccretion deleted the MorphBlockOperand-Struct-Removal-Upstream branch November 12, 2022 14:39
@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants