Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: increase edge weight slop tolerance some more #77747

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

AndyAyersMS
Copy link
Member

Allow up to 1/50 variance between the expected and computed values.

Fixes #77450.

Allow up to 1/50 variance between the expected and computed values.

Fixes dotnet#77450.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 1, 2022
@ghost ghost assigned AndyAyersMS Nov 1, 2022
@ghost
Copy link

ghost commented Nov 1, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Allow up to 1/50 variance between the expected and computed values.

Fixes #77450.

Author: AndyAyersMS
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@AndyAyersMS
Copy link
Member Author

@jakobbotsch PTAL
cc @dotnet/jit-contrib

(recall, all this will hopefully go away later in the .NET 8 cycle -- but it will be a few months)

@AndyAyersMS AndyAyersMS merged commit 82aa87f into dotnet:main Nov 2, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pgo] Assertion failed '((-slop) <= diff) && (diff <= slop)' during 'Compute edge weights (2, false)'
2 participants