Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating CreateScalar to be intrinsic for Vector64/128/256 #77798

Merged
merged 12 commits into from
Nov 11, 2022
Merged

Updating CreateScalar to be intrinsic for Vector64/128/256 #77798

merged 12 commits into from
Nov 11, 2022

Conversation

tannergooding
Copy link
Member

This ensures that vector constant nodes can be created and improves the codegen for inserts involving float.

Handling for Create(Vector128<T> lower, Vector128<T> upper) also needs to be done, but will be a separate PR.

@ghost ghost assigned tannergooding Nov 2, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 2, 2022
@ghost
Copy link

ghost commented Nov 2, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This ensures that vector constant nodes can be created and improves the codegen for inserts involving float.

Handling for Create(Vector128<T> lower, Vector128<T> upper) also needs to be done, but will be a separate PR.

Author: tannergooding
Assignees: tannergooding
Labels:

area-CodeGen-coreclr
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Nov 3, 2022
Closed
@tannergooding tannergooding marked this pull request as ready for review November 3, 2022 00:55
@tannergooding
Copy link
Member Author

CC. @dotnet/jit-contrib

@tannergooding
Copy link
Member Author

/azp run runtime-coreclr jitstress-isas-x86, runtime-coreclr jitstress-isas-arm, runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

This was referenced Nov 3, 2022
Closed
Closed
@tannergooding
Copy link
Member Author

outerloop failures are:

@tannergooding tannergooding mentioned this pull request Nov 4, 2022
Merged
EgorBo
EgorBo approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@EgorBo EgorBo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the test failures aren't related modulo the GT_CAST question.
Also, I assume it doesn't break mono since it converts a helper method into a "recursive" intrinsic

@tannergooding
Copy link
Member Author

CI failures are currently dotnet/arcade#11554. However, there is no way to tell if its masking actual issues or not so I'll hold off on merging.

@tannergooding tannergooding merged commit 00e6482 into dotnet:main Nov 11, 2022
@tannergooding tannergooding deleted the vector-create branch November 11, 2022 15:05
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SingleAccretion SingleAccretion SingleAccretion left review comments

@TIHan TIHan TIHan left review comments

@EgorBo EgorBo EgorBo approved these changes

Assignees

@tannergooding tannergooding

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tannergooding @EgorBo @TIHan @SingleAccretion