Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SharedFxLookup tests #77858

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Nov 3, 2022

These were a roundabout/confusing way of testing that we roll forward patch/minor for framework resolution by default and how we resolve dependencies based on assembly version when the dependency is included in multiple frameworks. We have existing tests that are clearer and lighter weight that do this.

Deleted:

  • Multiple_SharedFxLookup_NetCoreApp_MinorRollForward_Wins_Over_UberFx
    • two frameworks (uber, netcoreapp), rolls forward on minor version to use netcoreapp, netcoreapp has a higher assembly version, validates that assembly from netcoreapp is used
  • Multiple_SharedFxLookup_Uber_Wins_Over_NetCoreApp_On_PatchRollForward
    • two frameworks (uber, netcoreapp), rolls forward on patch version to use netcoreapp, uber has a higher assembly version, validates that assembly from uber is used

These are covered by AppPerAssemblyVersionResolutionMultipleFrameworks and RollForwardMultipleFrameworks.

These were a roundabout/confusing way of testing that we roll forward
patch/minor for framework resolution by default and how we resolve
dependencies based on assembly version when the dependency is included
in multiple frameworks. We have existing tests that are clearer and
lighter weight that do this.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Nov 3, 2022

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

These were a roundabout/confusing way of testing that we roll forward patch/minor for framework resolution by default and how we resolve dependencies based on assembly version when the dependency is included in multiple frameworks. We have existing tests that are clearer and lighter weight that do this.

Deleted:

  • Multiple_SharedFxLookup_NetCoreApp_MinorRollForward_Wins_Over_UberFx
    • two frameworks (uber, netcoreapp), rolls forward on minor version to use netcoreapp, netcoreapp has a higher assembly version, validates that assembly from netcoreapp is used
  • Multiple_SharedFxLookup_Uber_Wins_Over_NetCoreApp_On_PatchRollForward
    • two frameworks (uber, netcoreapp), rolls forward on patch version to use netcoreapp, uber has a higher assembly version, validates that assembly from uber is used

These are covered by AppPerAssemblyVersionResolutionMultipleFrameworks and RollForwardMultipleFrameworks.

Author: elinor-fung
Assignees: elinor-fung
Labels:

area-Host

Milestone: -

@elinor-fung elinor-fung merged commit bd274d7 into dotnet:main Nov 4, 2022
@elinor-fung elinor-fung deleted the removeSharedFxLookup branch November 4, 2022 14:53
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants