-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the stable 7.0.100 SDK #78034
Conversation
Thanks for getting this started -- I think we should also eventually do this for the 7.0 branch. |
@ViktorHofer is this blocked on something? |
@vzarytovskii is the error |
Not blocked on anything. We just need to spend some time to understand the build and test failures. Thanks @marek-safar for starting with that. |
Those resources may or may not be there, depending on which compiler version is used (newer versions are compressing resource, older do not). |
The error is actually a warning so we can suppress it. |
I don't think we want to suppress this warning for whole runtime repo and updating each affected project manually is not a great experience either. |
I have disabled trimming all resorces for |
false alarm: f# package has never included this resource. runtime has no control over that package. usage is same as before. so it should not raise to "error" level
there are five fsproj files in this repo and only one of them is trimmed: cbor test project. suppressing the warning in one file or removing cbor test project from trimming test should be alright for sdk update (esp when the error's severity itself is in question) |
Suppressing the linker warning about the missing F# resource was indeed just necessary in one project so I went with that. We can remove it once the F# fix propagates. The MacCatalyst failure is unrelated. |
No description provided.