Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Fixing memory ordering issue in ConcurrentQueue #78178

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 10, 2022

Backport of #78142 to release/7.0

/cc @VSadov

Customer Impact

ToArray/CopyTo/Enumerate operations on a ConcurrentQueue may fetch uninitialized data on arm64 under stress.

Testing

regular tests. manual stress-testing of the targeted scenario.

Risk

Very Low. we were just missing a Volatile.Read to enforce the order of reads in one place.

@ghost
Copy link

ghost commented Nov 10, 2022

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #78142 to release/7.0

/cc @VSadov

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Collections

Milestone: -

@VSadov VSadov requested a review from stephentoub November 10, 2022 17:56
@VSadov VSadov added the Servicing-consider Issue for next servicing release review label Nov 10, 2022
@carlossanlop
Copy link
Member

@VSadov if you haven't done so, please send an email to Tactics requesting approval. Monday 14th is the deadline for merging backports that we want in the December release so ideally we would like to get this merged tomorrow Friday.

@carlossanlop
Copy link
Member

Re-triggering the failed CI legs because they were affected by the widespread infra problem with docker images.

@VSadov
Copy link
Member

VSadov commented Nov 11, 2022

@carlossanlop the email has been sent

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 14, 2022
@carlossanlop carlossanlop added this to the 7.0.1 milestone Nov 14, 2022
@carlossanlop
Copy link
Member

This was approved by Tactics via email.
Signed off by area owners.
CI failure is known, pre-existing and unrelated: #77988 and a fix has already been merged to the base branch.
No OOB package authoring changes needed for System.Private.CoreLib.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit af314f3 into release/7.0 Nov 14, 2022
@carlossanlop carlossanlop deleted the backport/pr-78142-to-release/7.0 branch November 14, 2022 20:15
@ghost ghost locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Collections Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants