[Android] Prevent exceptions with a 'Success' message in System.Net.NetworkInformation

[simonrozsival]

There is a problem with permissions in new Android API levels (target SDK version 30+) causing NetworkChange.NetworkAddressChanged and NetworkInterface.GetAllNetworkInterfaces to throw an exception. The exception message would simply say "Success" which is quite confusing:

System.Net.NetworkInformation.NetworkInformationException (0x80004005): Success
   at System.Net.NetworkInformation.NetworkChange.CreateSocket()
   at System.Net.NetworkInformation.NetworkChange.add_NetworkAvailabilityChanged(NetworkAvailabilityChangedEventHandler )
   at Program.<Main>$(String[] ) in /.../dotnet/runtime/src/mono/sample/Android/Program.cs:line 10

The message is obtained by calling Interop.Sys.GetLastErrorInfo().GetErrorMessage() and the error code from Marshal.GetLastPInvokeError(), but the last pinvoke error code isn't preserved. This PR doesn't fix the underlying problem with accessing the network information but it fixes the exception message to reduce developer confusion.

The fixed exception stack trace:

System.Net.NetworkInformation.NetworkInformationException (13): Permission denied
   at System.Net.NetworkInformation.NetworkChange.CreateSocket()
   at System.Net.NetworkInformation.NetworkChange.add_NetworkAddressChanged(NetworkAddressChangedEventHandler )
   at Program.<Main>$(String[] ) in /.../dotnet/runtime/src/mono/sample/Android/Program.cs:line 9

Ref #77822
Ref #77938

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

There is a problem with permissions in new Android API levels (target SDK version 30+) causing NetworkChange.NetworkAddressChanged and NetworkInterface.GetAllNetworkInterfaces to throw an exception. The exception message would simply say "Success" which is quite confusing:

System.Net.NetworkInformation.NetworkInformationException (0x80004005): Success
   at System.Net.NetworkInformation.NetworkChange.CreateSocket()
   at System.Net.NetworkInformation.NetworkChange.add_NetworkAvailabilityChanged(NetworkAvailabilityChangedEventHandler )
   at Program.<Main>$(String[] ) in /.../dotnet/runtime/src/mono/sample/Android/Program.cs:line 10

The message is obtained by calling Interop.Sys.GetLastErrorInfo().GetErrorMessage() and the error code from Marshal.GetLastPInvokeError(), but the last pinvoke error code isn't preserved. This PR doesn't fix the underlying problem with accessing the network information but it fixes the exception message to reduce developer confusion.

The fixed exception stack trace:

System.Net.NetworkInformation.NetworkInformationException (13): Permission denied
   at System.Net.NetworkInformation.NetworkChange.CreateSocket()
   at System.Net.NetworkInformation.NetworkChange.add_NetworkAddressChanged(NetworkAddressChangedEventHandler )
   at Program.<Main>$(String[] ) in /.../dotnet/runtime/src/mono/sample/Android/Program.cs:line 9

Ref #77822
Ref #77938

Author:	simonrozsival
Assignees:	-
Labels:	area-System.Net, os-android
Milestone:	-

[simonrozsival]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).