Place non-GC statics in the dehydratable section #78795
Conversation
ghost
assigned 
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsThere can be a pointer reloc that points to the class constructor. We need this to stay as a full pointer since non-Gc statics can be allocated at runtime and we don't have guarantees they would be within +-2 GB of the cctor. Cc @dotnet/ilc-contrib
|
| @@ -47,7 +47,7 @@ public bool IsStandardSection | |||
| public static readonly ObjectNodeSection FoldableReadOnlyDataSection = new ObjectNodeSection("rdata", SectionType.ReadOnly); | |||
| public static readonly ObjectNodeSection TextSection = new ObjectNodeSection("text", SectionType.Executable); | |||
| public static readonly ObjectNodeSection TLSSection = new ObjectNodeSection("TLS", SectionType.Writeable); | |||
| public static readonly ObjectNodeSection BssSection = new ObjectNodeSection("bss", SectionType.Writeable); | |||
| public static readonly ObjectNodeSection BssSection = new ObjectNodeSection("bss", SectionType.Uninitialized); | |||
There was a problem hiding this comment.
I've confirmed in the CI logs this also fixes the linker warning in multimodule testing: MultiModule.obj : warning LNK4078: multiple '.bss' sections found with different attributes (C0401040). Yay.
|
|
||
| // If the data would be placed into an uninitialized section, that's better | ||
| // than dehydrating a bunch of zeros. | ||
| skipDehydrating |= GetDehydratedSection(factory).Type == SectionType.Uninitialized; |
There was a problem hiding this comment.
nit: maybe the shared logic could be moved into a helper to ensure it's consistent between GetSection and GetData (I had to read this a couple times to convince myself it was right, but it may just be me).
There was a problem hiding this comment.
I tried with a bool CanDehydrate(ObjectNodeSection desiredSection) but the shape of the helper (need to pass the section to make a decision) made it a bit weird. I'll keep it like this for now.
There can be a pointer reloc that points to the class constructor. We need this to stay as a full pointer since non-Gc statics can be allocated at runtime and we don't have guarantees they would be within +-2 GB of the cctor.
Cc @dotnet/ilc-contrib