Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tizen x64 cross build support #79226

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

gbalykov
Copy link
Member

@gbalykov gbalykov commented Dec 5, 2022

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 5, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

eng/native/tryrun.cmake Outdated Show resolved Hide resolved
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@am11 Does it look good to you as well?

eng/native/tryrun.cmake Outdated Show resolved Hide resolved
@am11
Copy link
Member

am11 commented Dec 6, 2022

One nit, overall looks good. 👍

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@jkotas
Copy link
Member

jkotas commented Dec 6, 2022

Failures are #79279

@jkotas jkotas merged commit b8d4b8a into dotnet:main Dec 6, 2022
@gbalykov
Copy link
Member Author

gbalykov commented Dec 6, 2022

Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants