Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Processor Count getting ignored due to typo in libs/build-native.proj #79249

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Fix Processor Count getting ignored due to typo in libs/build-native.proj #79249

merged 1 commit into from
Dec 6, 2022

Conversation

ivdiazsa
Copy link
Member

@ivdiazsa ivdiazsa commented Dec 5, 2022

As I was playing around with the native build scripts, I found that a typo in libs/build-native.proj was rendering the Processor Count argument unusable. This PR addresses and fixes it.

@ivdiazsa ivdiazsa added this to the 8.0.0 milestone Dec 5, 2022
@ghost ghost assigned ivdiazsa Dec 5, 2022
@ghost
Copy link

ghost commented Dec 5, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

As I was playing around with the native build scripts, I found that a typo in libs/build-native.proj was rendering the Processor Count argument unusable. This PR addresses and fixes it.

Author: ivdiazsa
Assignees: -
Labels:

area-Infrastructure

Milestone: 8.0.0

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you for fixing this!

@marek-safar marek-safar merged commit d45904a into dotnet:main Dec 6, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 5, 2023
@ivdiazsa ivdiazsa deleted the native-libs-typewriter branch April 24, 2023 22:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants