Fix for COM Weakreference test failure under JIT stress. #79476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
src/tests/Interop/COM/ComWrappers/WeakReference/WeakReferenceTest.cs
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Dec 9, 2022
|
Thanks!!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIT stress changes inlining heuristics and may cause methods to inline when they otherwise would not. That can extend life times of locals and temps in those methods.
If a testcase depends on the local/temps life times to be within some method, it needs to ensure that the method is not inlined, so that the testcase behavior is the same regardless of JIT settings.
Fixes: #78945