[release/7.0] Fix WXORX issue in EEClass::Destruct #79703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
While investigating failures of some coreclr tests when running in an unloadable context, I've hit AV in EEClass::Destruct in one of the tests. The reason is that we are missing ExecutableWriterHolder when updating refCount on pDelegateEEClass->m_pInstRetBuffCallStub. This change fixes it.
jkotas
approved these changes
Dec 15, 2022
jeffschwMSFT
approved these changes
Dec 16, 2022
rbhanda
added
Servicing-approved
|
This is CoreCLR-specific change. All CI failures are in Mono and thus unrelated. |
|
Approved by Tactics (7.0.3). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #79696 to release/7.0
/cc @janvorli
Customer Impact
.NET runtime with W^X enabled crashes with access violation when unloading code that uses delegates set to instance methods that require return buffer for their return value.
Testing
coreclr tests executed in unloadable assembly load context.
Risk
Low, the location that the fix modifies would always crash with AV with W^X and the change is effectively no-op with W^X disabled.