JIT: Fix indir flags propagation for a couple of cases #79751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SetIndirExceptionFlags expects only unary indirs (reads) and does not handle other cases correctly. Add an assert for it and fix the users. Only fgMorphStoreDynBlock had the bug since gtUpdateNodeOperSideEffects assumes the caller will propagate effect flags from operands afterwards. Extracted from early liveness PR. Fix dotnet#79750
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsSetIndirExceptionFlags expects only unary indirs (reads) and does not handle other cases correctly. Add an assert for it and fix the users. Only fgMorphStoreDynBlock had the bug since gtUpdateNodeOperSideEffects assumes the caller will propagate effect flags from operands afterwards. Extracted from #79346. Fix #79750
|
|
cc @dotnet/jit-contrib PTAL @BruceForstall |
BruceForstall
approved these changes
Dec 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetIndirExceptionFlags expects only unary indirs (reads) and does not handle other cases correctly. Add an assert for it and fix the users.
Only fgMorphStoreDynBlock had the bug since gtUpdateNodeOperSideEffects assumes the caller will propagate effect flags from operands afterwards.
Extracted from #79346.
Fix #79750