Skip parsing types in ILLinkTrim.Descriptors if not needed #79803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not even be using this parser (dotnet#79802). It's surprisingly slow to use this. This saves about 10% of wallclock time when compiling Hello World (yes, I can't believe my measurements either). We parse the descriptors for the purposes of manifest resources pretty late in the single threaded phase.
ghost
assigned 
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsWe should not even be using this parser (#79802). It's surprisingly slow. This saves about 10% of wallclock time when compiling Hello World (yes, I can't believe my measurements either). We parse the descriptors for the purposes of manifest resources pretty late in the single threaded phase and apparently there's a lot of things to parse that we don't care about. Cc @dotnet/ilc-contrib
|
benaadams
reviewed
Dec 19, 2022
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ProcessXmlBase.cs
Outdated
Show resolved
Hide resolved
…ase.cs Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
vitek-karas
approved these changes
Dec 19, 2022
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not even be using this parser (#79802). It's surprisingly slow.
This saves about 10% of wallclock time when compiling Hello World (yes, I can't believe my measurements either). We parse the descriptors for the purposes of manifest resources pretty late in the single threaded phase and apparently there's a lot of things to parse that we don't care about.
Cc @dotnet/ilc-contrib