Fix build for DUMP_GC_TABLES defined in Release #79835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue Detailsnull
|
|
This plus changing: in jit.h allows building a Release JIT that dumps the GC info. |
BrianBohe
reviewed
Dec 19, 2022
src/coreclr/jit/gcencode.cpp
Outdated
| gcDump.gcPrintf = gcDump_logf; // use my printf (which logs to VM) | ||
| #else | ||
| gcDump.gcPrintf = printf; |
There was a problem hiding this comment.
Are you using jitstdout for release because of speed?
There was a problem hiding this comment.
Enabling gcDump_logf to build when DEBUG is not defined but DUMP_GC_TABLES is defined seemed like more work, and possibly not necessary to achieve the goal, so I went for a simpler build fix.
BrianBohe
approved these changes
Dec 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.