createdump: only dump committed memory #79853
Conversation
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @tommcdon Issue DetailsDumping memory regions as they are listed in This change uses Fixes #71472
|
|
The same |
ezsilmar
force-pushed
the
createdump_only_dump_committed_memory
branch
from
3acb407 to
3c36826
Compare
|
Oh I messed up the branch trying to update it to the tip of the main... I'll try to fix it |
Dumping memory regions as they are listed in /proc/pid/maps results in increase of RAM usage of the target application on some Linux kernels. This change uses /proc/pid/pagemap to check if the page is committed before adding it to the regions list. As the file is not available on kernels 4.0 and 4.1 without elevated permissions there's a fallback to previous behavior.
ezsilmar
force-pushed
the
createdump_only_dump_committed_memory
branch
from
3c36826 to
07d8aff
Compare
|
Error is known and tracked in build analysis |
|
Thanks @ezsilmar! |
|
Is it possible to get the fixed |
Dumping memory regions as they are listed in /proc/pid/maps results in increase of RAM usage of the target application on some Linux kernels. This change uses /proc/pid/pagemap to check if the page is committed before adding it to the regions list. As the file is not available on kernels 4.0 and 4.1 without elevated permissions there's a fallback to previous behavior. Conflicts: src/coreclr/debug/createdump/crashinfo.cpp src/coreclr/debug/createdump/crashinfo.h
|
createdump uses libmscordaccore. There's been quite a few changes from 8.0 to 6.0. This change would need to be ported to 6.0 - I'll need to do some testing, but generally I've heard interest to take it into servicing. I'll prepare the patch, but it might be a while for it to go into the proper released product. |
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3784244575 |
Dumping memory regions as they are listed in
/proc/pid/mapsresults in increase of RAM usage of the target application on some Linux kernels.This change uses
/proc/pid/pagemapto check if the page is committed before adding it to the regions list. As the file is not available on kernels 4.0 and 4.1 without elevated permissions there's a fallback to previous behavior.Fixes #71472