Dispose underlying stream in TarReader.DisposeAsync() as well #79920
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsSame as #79899 but for the async dispose method. In the System.Formats.Tar WriteEntry_LongFileSize/WriteEntry_LongFileSizeAsync tests the stream passed to
|
| using System.IO; | ||
|
|
||
| namespace System.Formats.Tar | ||
| namespace System.IO | ||
| { | ||
| public class WrappedStream : Stream |
There was a problem hiding this comment.
@carlossanlop do you remember which changes you meant back in #67883 (comment) ?
It seems to work with the consolidated version.
|
/azp list |
|
/azp run runtime-libraries-coreclr outerloop-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Some of the outerloops tests have failed due to timeouts: I am going to merge this PR as it's fixing a product bug and reopen #77012 to keep track of the required test changes. |
…#79920) * Dispose underlying stream in TarReader.DisposeAsync() as well Same as dotnet#79899 * Consolidate duplicated WrappedStream test helpers to Common sources * Dispose stream passed to WrappedStream
… is false (#80598) * TarReader should dispose underlying stream if leaveOpen is false (#79899) * Dispose underlying stream in TarReader.DisposeAsync() as well (#79920) * Dispose underlying stream in TarReader.DisposeAsync() as well Same as #79899 * Consolidate duplicated WrappedStream test helpers to Common sources * Dispose stream passed to WrappedStream * Dispose archive stream after the list of DataStreams (#80572) * Dispose archive stream after the list of DataStreams * Add tests for TarReader.DisposeAsync properly disposing underlying stream Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
ghost
locked as resolved and limited conversation to collaborators
Same as #79899 but for the async dispose method.
In the System.Formats.Tar WriteEntry_LongFileSize/WriteEntry_LongFileSizeAsync tests the stream passed to
WrappedStreamwas also not disposed, causing it to stick around longer (see #79907). While looking at adding that I found out we have two nearly identical copies of the helper class in both System.Formats.Tar and System.IO.Compression, but a test in the latter one relies onWrappedStreamnot disposing the stream internally so I just consolidated to a single source file and and separately dispose of the stream passed toWrappedStreamin the System.Formats.Tar tests.