Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete ProcessXmlBase #79980

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Delete ProcessXmlBase #79980

merged 2 commits into from
Dec 28, 2022
+62 −434

Conversation

Suchiman
Copy link
Contributor

fixes #79802

Is there any particular reason to use XDocument.XPathNavigator instead of using much nicer XDocument APIs directly?

cc @MichalStrehovsky

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 26, 2022
@ghost
Copy link

ghost commented Dec 26, 2022

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #79802

Is there any particular reason to use XDocument.XPathNavigator instead of using much nicer XDocument APIs directly?

cc @MichalStrehovsky

Author: Suchiman
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: -

MichalStrehovsky
MichalStrehovsky approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Is there any particular reason to use XDocument.XPathNavigator instead of using much nicer XDocument APIs directly?

We keep this implementation very close (ideally line-by-line) to how this works in IL Linker. The decision was made there...

@MichalStrehovsky
Copy link
Member

Cc @dotnet/ilc-contrib more unification with illinker

@MichalStrehovsky MichalStrehovsky merged commit 4131a83 into dotnet:main Dec 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

Assignees
No one assigned
Labels
area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete ProcessXmlBase.cs
2 participants
@Suchiman @MichalStrehovsky