Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] AOT BCL tests using -O1 to avoid OOM errors on CI. #80103

Merged
merged 1 commit into from
Jan 4, 2023
Merged

[wasm] AOT BCL tests using -O1 to avoid OOM errors on CI. #80103

merged 1 commit into from
Jan 4, 2023

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Jan 2, 2023 •
edited by radical
Loading

Fixes #79874
Fixes #79569

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned vargaz Jan 2, 2023
@vargaz
Copy link
Contributor Author

vargaz commented Jan 2, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jan 3, 2023
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Jan 3, 2023
Closed
@vargaz
Copy link
Contributor Author

vargaz commented Jan 3, 2023

/azp run runtime-wasm-libtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Jan 3, 2023
Open
@vargaz vargaz changed the title [wasm] Disable AOT-ing a few assemblies in the System.Runtime tests t… [wasm] AOT BCL tests using -O1 to avoid OOM errors on CI. Jan 3, 2023
@vargaz vargaz marked this pull request as ready for review January 3, 2023 21:39
@vargaz vargaz requested a review from lewing January 3, 2023 21:39
@vargaz
Copy link
Contributor Author

vargaz commented Jan 3, 2023

/azp run runtime-wasm-libtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
Copy link
Contributor Author

vargaz commented Jan 3, 2023

/azp run runtime-wasm-libtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Jan 4, 2023
Closed
@vargaz
Copy link
Contributor Author

vargaz commented Jan 4, 2023

There are failures in the System.Text.Json tests, but they might have been introduced when the tests were failing to build.

@radical
Copy link
Member

radical commented Jan 4, 2023

There are failures in the System.Text.Json tests, but they might have been introduced when the tests were failing to build.

Yep, unrelated to this PR. They have been failing only on rolling builds, and got through because we weren't watching those over the holidays.

@radical
Copy link
Member

radical commented Jan 4, 2023

Opened an issue for that - #80179 .

@vargaz vargaz merged commit 2072f16 into dotnet:main Jan 4, 2023
@vargaz vargaz deleted the fix-wasm-aot branch January 4, 2023 15:10
@lewing lewing mentioned this pull request Jan 5, 2023
Closed
4 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek left review comments

@radical radical radical approved these changes

@lewing lewing Awaiting requested review from lewing

Assignees

@vargaz vargaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

emcc received SIGKILL [wasm] Library tests failing during linking for AOT - SIGKILL
3 participants
@vargaz @radical @lambdageek