Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Move microbenchmarks, and blazor SOD runs to net8.0 #80308

Merged
merged 3 commits into from
Jan 13, 2023
Merged

[wasm] Move microbenchmarks, and blazor SOD runs to net8.0 #80308

merged 3 commits into from
Jan 13, 2023

Conversation

radical
Copy link
Member

@radical radical commented Jan 6, 2023 •
edited
Loading

  • Use dotnet-latest instead of dotnet-net7+latest for running benchmarks. The former only has wasm-tools workload installed. And is sufficient for net8.0 projects, and would break any projects trying to build for net7.0 .
  • Fix up blazor timeout to increase from the default 5mins to 30mins, since the AOT ones (template) are taking longer
  • Various changes to help with diagnostics, and debugging

@radical radical added arch-wasm WebAssembly architecture perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines labels Jan 6, 2023
@ghost ghost assigned radical Jan 6, 2023
@ghost
Copy link

ghost commented Jan 6, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

arch-wasm, perf-pipeline
Milestone: -

@radical radical changed the title [wasm] test perf branch for 8.0 [wasm] Move microbenchmarks, and blazor SOD runs to net8.0 Jan 6, 2023
@radical
Copy link
Member Author

radical commented Jan 6, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jan 6, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jan 6, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jan 7, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical GitHub Codespaces
Copy link
Member Author

radical commented Jan 7, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical GitHub Codespaces
Copy link
Member Author

radical commented Jan 7, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@radical GitHub Codespaces
Copy link
Member Author

radical commented Jan 7, 2023

/azp run runtime-wasm-perf

@build-analysis build-analysis bot mentioned this pull request Jan 7, 2023
Closed
@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@radical GitHub Codespaces
Copy link
Member Author

radical commented Jan 7, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@radical GitHub Codespaces
Copy link
Member Author

radical commented Jan 7, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical GitHub Codespaces
Copy link
Member Author

radical commented Jan 7, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical GitHub Codespaces
Copy link
Member Author

radical commented Jan 7, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical GitHub Codespaces
Copy link
Member Author

radical commented Jan 7, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jan 9, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical mentioned this pull request Jan 9, 2023
Closed
@radical GitHub Codespaces
Copy link
Member Author

radical commented Jan 9, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jan 9, 2023
Closed
Closed
@radical radical marked this pull request as ready for review January 10, 2023 05:24
@radical
Copy link
Member Author

radical commented Jan 10, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jan 10, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
[wasm] perf: generate, and collect binlogs
040caff
@radical
[wasm] perf: remove workaround to allow building for net8.0 with 8.0 sdk
e29d39a
@radical
[wasm] perf: revert to using latest v8
2ffcc61 
- this is because jsvu fails to generate a wrapper for the specific
  version, because this version of jsvu (2.0.1) is broken with node 14.x
  . And node 18.x builds are not built for ubuntu 18.04
@radical
Copy link
Member Author

radical commented Jan 12, 2023

Also waiting on dotnet-runtime-perf run.

@radical
Copy link
Member Author

radical commented Jan 13, 2023

All the wasm jobs passed on https://dev.azure.com/dnceng/internal/_build/results?buildId=2087129&view=results . Except for one AOT job that had a timeout during AOT. That does not need to block this PR though. I'll investigate it separately.

@radical
Copy link
Member Author

radical commented Jan 13, 2023

Oh, and looks like that one is on the one possibly bad machine - PERFTIGER200!

@radical
Copy link
Member Author

radical commented Jan 13, 2023

Other failures here are unrelated. Merging.

@radical radical merged commit f97f5be into dotnet:main Jan 13, 2023
@radical radical deleted the perf-8 branch January 13, 2023 02:42
@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@DrewScoggins DrewScoggins Awaiting requested review from DrewScoggins

@LoopedBard3 LoopedBard3 Awaiting requested review from LoopedBard3

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radical @lewing