[release/7.0] Restore Advance when reading float/double with XmlBufferReader. #80321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
StephenMolloy
added
the
Servicing-consider
|
runtime-dev-innerloop failure is #80284 |
HongGit
approved these changes
Jan 9, 2023
HongGit
added
Servicing-approved
|
@carlossanlop Is there a fix in progress for the source build issue |
Not yet. It's being actively investigated. Here is the issue tracking it: #80284 |
|
@mmitche @StephenMolloy is that issue a blocker for merging this PR? Edit: I'll assume it's not a blocker, since Stephen mentioned it in a comment. |
|
Approved by Tactics (7.0.3). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #80274 to release/7.0
Fixes #78913, #79056, and #79092
/cc @StephenMolloy
Customer Impact
A combination of performance and big-endian changes towards the end of 7.0 broke binary-deserialization of float/doubles in DataContractSerializer. Values are still serialized correctly, but 7.0 DCS clients fail when reading those primative types. The description on #80274 gets into more root-cause details.
Testing
Testing already existed for the correctness of the bytes being written and the order they get read back in... but that testing was targeted and shortcutted the buffered reader that DCS uses in end-to-end scenarios. This PR adds a quick round-trip check to our existing end-to-end DCS tests for most types.
Risk
Low. The change is small and represents an understood restoration of behavior from previous versions.