-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harden and re-enable DualMode socket tests #80715
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsDropping
|
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
@wfurt do you want to take a look, or should I go ahead and merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I would probably go with disabled parallelization but I'm fine with the helper if you feel it would stabilize the test. Time will tell and keeping the test disable does not provide any benefits.
I think that some of the re-enabled / shuffled tests are failing on extra platform pipeline:
cc: @antonfirsov |
Fixes #1481.
Fixes #79820.
Throwing
DisableParallelization
at all tests in DualModeSocketTest increased the total execution time of those tests by approximately 1 minute on my Windows machine, so I decided to go with a more sophisticated approach.PortBlocker
, which creates and binds a "shadow" socket of the opposite address family to prevent sockets in parallel tests to bind to the same port.SocketTestHelperBase<T>
, reducing duplicate code.