Fix dynamic class zeroing #80822
Merged
Fix dynamic class zeroing #80822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent change in the `ThreadLocalModule::AllocateDynamicClass` has accidentally removed zeroing for new CollectibleDynamicEntry instances. That leads to crashes when running code in an unloadable context. This change fixes that.
jkoritzinsky
approved these changes
Jan 18, 2023
mdh1418
pushed a commit
to mdh1418/runtime
that referenced
this pull request
Jan 24, 2023
Recent change in the `ThreadLocalModule::AllocateDynamicClass` has accidentally removed zeroing for new CollectibleDynamicEntry instances. That leads to crashes when running code in an unloadable context. This change fixes that.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent change in the
ThreadLocalModule::AllocateDynamicClasshas accidentally removed zeroing for newCollectibleDynamicEntryinstances. That leads to crashes when running code in an unloadable context.It got exposed by weekly coreclr test runs with the
runincontextoption.This change fixes that.