Add expected output tests for regex source generator #80937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsIn particular to help avoid significant formatting / readability regressions in the code output by the regex generator. Fixes #63300
|
eerhardt
reviewed
Jan 20, 2023
src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/RegexGeneratorOutputTests.cs
Show resolved
Hide resolved
In particular to help avoid significant formatting / readability regressions in the code output by the regex generator.
stephentoub
force-pushed
the
addexpectedoutputtests
branch
from
53db90d
to
a725e37
Compare
eerhardt
approved these changes
Jan 23, 2023
mdh1418
pushed a commit
to mdh1418/runtime
that referenced
this pull request
Jan 24, 2023
* Add expected output tests for regex In particular to help avoid significant formatting / readability regressions in the code output by the regex generator. * Address PR feedback to normalize version
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular to help avoid significant formatting / readability regressions in the code output by the regex generator.
Fixes #63300