Beef up WithoutFunctionPointerType
#81147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have a `MethodTable` shape for function pointer types because how they should look like hasn't been defined until .NET 8. Beef up the CoreCLR compat shim. We'll not be 100% compatible with this because `typeof(Tuple<delegate*<void>[]>)` doesn't actually load as `typeof(Tuple<IntPtr[]>)`, but this'll do until dotnet#71883.
ghost
assigned 
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsFixes #81117 We don't have a Beef up the CoreCLR compat shim. We'll not be 100% compatible with this because Cc @dotnet/ilc-contrib
|
jkotas
reviewed
Jan 25, 2023
| { | ||
| switch (type.Category) | ||
| { | ||
| case TypeFlags.Array: |
There was a problem hiding this comment.
Skip the parametrized type lookup if there is no change in the parameter - similar to how it is done for the generic case below?
jkotas
approved these changes
Jan 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81117
We don't have a
MethodTableshape for function pointer types because how they should look like hasn't been defined until .NET 8.Beef up the CoreCLR compat shim. We'll not be 100% compatible with this because
typeof(Tuple<delegate*<void>[]>)doesn't actually load astypeof(Tuple<IntPtr[]>), but this'll do until #71883.Cc @dotnet/ilc-contrib