[wasm][debug] Avoid pausing on breakpoint while invoking methods. #81162

thaystg · 2023-01-25T13:33:48Z

This is trying to proactively fix a potential issue. It was prompted by this error on CI while running test SteppingIntoLibrarySymbolsLoadedFromSymbolServerRemoveSymbolServerAndStepAgain:

Error while evaluating ToString method: Microsoft.WebAssembly.Diagnostics.DebuggerAgentException:
    SendDebuggerAgentCommand failed for InvokeMethod: [Result: IsOk: False, IsErr: True, Value: ,
        Error: {
            "result": {
                "type": "object",
                "subtype": "error",
                "className": "RuntimeError",
                "description": "RuntimeError: memory access out of bounds
                                at create_event_list (http://localhost:9400/dotnet.wasm:wasm-function[1360]:0x709ca)
                                at mono_dbg_create_breakpoint_events (http://localhost:9400/dotnet.wasm:wasm-function[1359]:0x70490)
                                at mono_de_process_single_step (http://localhost:9400/dotnet.wasm:wasm-function[1250]:0x6a78a)
                                at mono_wasm_single_step_hit (http://localhost:9400/dotnet.wasm:wasm-function[1194]:0x68095)
                                at do_debugger_tramp (http://localhost:9400/dotnet.wasm:wasm-function[259]:0x19dd6)
                                at mono_interp_exec_method (http://localhost:9400/dotnet.wasm:wasm-function[256]:0x17409)
                                at interp_runtime_invoke (http://localhost:9400/dotnet.wasm:wasm-function[288]:0x1b5bd)
                                at mono_jit_runtime_invoke (http://localhost:9400/dotnet.wasm:wasm-function[15887]:0x299e5e)
                                at do_runtime_invoke (http://localhost:9400/dotnet.wasm:wasm-function[3412]:0xf5296)
                                at mono_runtime_try_invoke (http://localhost:9400/dotnet.wasm:wasm-function[3426]:0xf5fc6)",
                "objectId": "-2154664807079430451.2.463" 
                }
             }]

I run it all the night locally and couldn't reproduce it again, the test was executed 812 times.

Looking at the proxy log, console.warning: MONO_WASM: Adding an id (0) that already exists in commands_received"
message was seen it. And based on reading the code, my understanding is:

This is a case where a method is called, while we are already PAUSEd.
For example, if we are paused in a method foo.run()
- then a breakpoint is set in foo.method(){} [1]
- then we evaluate the expression foo.method()
- the second breakpoint in foo.method should not cause any failures, or cause a second pause
The missing fix here is to set ..
invoke_data.flags = INVOKE_FLAG_DISABLE_BREAKPOINTS;
.. when invoking the method in the runtime.
- this change is correct irrespective of anything else
A related issue is seen when we are stepping through the code (global
stepping), and call a method while paused. The debugger agent behaves as it
is stepping through code while running this method.
- To fix this, we disable breakpoints, and stepping while a method a being
  invoked in the runtime.
Since, we failed to reproduce the original issue, the test has to depend on
the original message seen. And test checks for the absence of this message.
As long as the test passes it means that the above case does not cause any
failures

--

we also test the case of the breakpoint in foo.method() being set before
foo.run() is called at all

ghost · 2023-01-25T13:34:01Z

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Trying to fix the error on CI while running test SteppingIntoLibrarySymbolsLoadedFromSymbolServerRemoveSymbolServerAndStepAgain:

| [2023-01-25T01:48:06] DevToolsProxy-3 Debug: Error while evaluating ToString method: Microsoft.WebAssembly.Diagnostics.DebuggerAgentException: SendDebuggerAgentCommand failed for InvokeMethod: [Result: IsOk: False, IsErr: True, Value: , Error: {
 |                                                "result": {
 |                                                  "type": "object",
 |                                                  "subtype": "error",
 |                                                  "className": "RuntimeError",
 |                                                  "description": "RuntimeError: memory access out of bounds\n    at create_event_list (http://localhost:9400/dotnet.wasm:wasm-function[1360]:0x709ca)\n    at mono_dbg_create_breakpoint_events (http://localhost:9400/dotnet.wasm:wasm-function[1359]:0x70490)\n    at mono_de_process_single_step (http://localhost:9400/dotnet.wasm:wasm-function[1250]:0x6a78a)\n    at mono_wasm_single_step_hit (http://localhost:9400/dotnet.wasm:wasm-function[1194]:0x68095)\n    at do_debugger_tramp (http://localhost:9400/dotnet.wasm:wasm-function[259]:0x19dd6)\n    at mono_interp_exec_method (http://localhost:9400/dotnet.wasm:wasm-function[256]:0x17409)\n    at interp_runtime_invoke (http://localhost:9400/dotnet.wasm:wasm-function[288]:0x1b5bd)\n    at mono_jit_runtime_invoke (http://localhost:9400/dotnet.wasm:wasm-function[15887]:0x299e5e)\n    at do_runtime_invoke (http://localhost:9400/dotnet.wasm:wasm-function[3412]:0xf5296)\n    at mono_runtime_try_invoke (http://localhost:9400/dotnet.wasm:wasm-function[3426]:0xf5fc6)",
 |                                                  "objectId": "-2154664807079430451.2.463"

I run it all the night locally and couldn't reproduce it again, the test was executed 812 times.

Author:	thaystg
Assignees:	-
Labels:	`area-Debugger-mono`
Milestone:	-

ghost · 2023-01-25T13:57:05Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Trying to fix the error on CI while running test SteppingIntoLibrarySymbolsLoadedFromSymbolServerRemoveSymbolServerAndStepAgain:

| [2023-01-25T01:48:06] DevToolsProxy-3 Debug: Error while evaluating ToString method: Microsoft.WebAssembly.Diagnostics.DebuggerAgentException: SendDebuggerAgentCommand failed for InvokeMethod: [Result: IsOk: False, IsErr: True, Value: , Error: {
 |                                                "result": {
 |                                                  "type": "object",
 |                                                  "subtype": "error",
 |                                                  "className": "RuntimeError",
 |                                                  "description": "RuntimeError: memory access out of bounds\n    at create_event_list (http://localhost:9400/dotnet.wasm:wasm-function[1360]:0x709ca)\n    at mono_dbg_create_breakpoint_events (http://localhost:9400/dotnet.wasm:wasm-function[1359]:0x70490)\n    at mono_de_process_single_step (http://localhost:9400/dotnet.wasm:wasm-function[1250]:0x6a78a)\n    at mono_wasm_single_step_hit (http://localhost:9400/dotnet.wasm:wasm-function[1194]:0x68095)\n    at do_debugger_tramp (http://localhost:9400/dotnet.wasm:wasm-function[259]:0x19dd6)\n    at mono_interp_exec_method (http://localhost:9400/dotnet.wasm:wasm-function[256]:0x17409)\n    at interp_runtime_invoke (http://localhost:9400/dotnet.wasm:wasm-function[288]:0x1b5bd)\n    at mono_jit_runtime_invoke (http://localhost:9400/dotnet.wasm:wasm-function[15887]:0x299e5e)\n    at do_runtime_invoke (http://localhost:9400/dotnet.wasm:wasm-function[3412]:0xf5296)\n    at mono_runtime_try_invoke (http://localhost:9400/dotnet.wasm:wasm-function[3426]:0xf5fc6)",
 |                                                  "objectId": "-2154664807079430451.2.463"

I run it all the night locally and couldn't reproduce it again, the test was executed 812 times.

Author:	thaystg
Assignees:	thaystg
Labels:	`arch-wasm`, `area-Debugger-mono`
Milestone:	-

thaystg · 2023-01-31T16:26:13Z

/azp run runtime-wasm-non-libtests

azure-pipelines · 2023-01-31T16:26:24Z

Azure Pipelines successfully started running 1 pipeline(s).

src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs

radical · 2023-01-31T18:46:51Z

src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs

+        public async Task WaitForWarningMessage(string message)
+        {
+            object llock = new();
+            var tcs = new TaskCompletionSource();


Should this method take a CancellationToken, cancel this tcs when the token is cancelled?

I'm not sure, I copied from the method that you wrote WaitForScriptParsedEventsAsync.
If you think we should please let me know and probably we should change both.

radical · 2023-01-31T19:48:25Z

src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs

+        [ConditionalFact(nameof(RunningOnChrome))]
+        public async Task EvaluateMethodAndCheckIsNotPausingOnBreakpoint()
+        {
+            var waitForScript = WaitForWarningMessage("console.warning: MONO_WASM: Adding an id (0) that already exists in commands_received");


What does this message mean, and why are we waiting to see that we don't get it?

This message means that we are paused in a breakpoint and we are receiving another pause.
With the fix we don't see the message anymore.

radical · 2023-01-31T19:55:17Z

src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs

@@ -870,5 +870,23 @@ public async Task EvaluatePropertyThatThrows()
               props = await GetObjectOnFrame(frame, "this");
               CheckNumber(props, "a", 11);
           });
+
+        [ConditionalFact(nameof(RunningOnChrome))]
+        public async Task EvaluateMethodAndCheckIsNotPausingOnBreakpoint()


We should also add tests which do this but with an actual breakpoint.

void Foo() { // bp here } void Method1() { Method2(); } void Method2() { ... // bp set here }

set bp in Foo, and Method2

if we are originally stopped at bp in Foo

then we call Method1, we should no break again at Method2

And the same thing with a property getter - explicitly invoked, bp in the getter or a method called by that getter

And the same thing with a property getter - implicitly invoked because we were evaluating properties on some local var

src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs

src/mono/wasm/debugger/DebuggerTestSuite/Inspector.cs

thaystg · 2023-02-01T19:26:53Z

/azp run runtime-wasm-non-libtests

azure-pipelines · 2023-02-01T19:27:04Z

Azure Pipelines successfully started running 1 pipeline(s).

radical · 2023-02-01T23:47:43Z

/azp run runtime-wasm-dbgtests

azure-pipelines · 2023-02-01T23:47:51Z

Azure Pipelines failed to run 1 pipeline(s).

src/mono/mono/component/debugger-agent.c

thaystg · 2023-02-02T17:05:11Z

/azp run runtime-wasm-dbgtests

azure-pipelines · 2023-02-02T17:05:22Z

Azure Pipelines successfully started running 1 pipeline(s).

…e into thays_fix_symbolServer_CI

thaystg · 2023-02-02T21:49:27Z

/azp run runtime-wasm-dbgtests

azure-pipelines · 2023-02-02T21:49:37Z

Azure Pipelines successfully started running 1 pipeline(s).

…expression.

thaystg · 2023-02-05T23:19:19Z

/azp run runtime-wasm-dbgtests

azure-pipelines · 2023-02-05T23:19:27Z

Azure Pipelines successfully started running 1 pipeline(s).

src/mono/mono/component/debugger-agent.c

thaystg · 2023-02-06T18:14:48Z

/azp run runtime-wasm-dbgtests

azure-pipelines · 2023-02-06T18:14:57Z

Azure Pipelines successfully started running 1 pipeline(s).

radical

LGTM! And good job on tracking this one down with almost no information, or being able to reproduce it!

thaystg · 2023-02-07T20:16:47Z

LGTM! And good job on tracking this one down with almost no information, or being able to reproduce it!

You helped a lot, thanks!

Trying to avoid pausing on breakpoint while invoking methods.

8b19a6d

thaystg requested a review from marek-safar as a code owner January 25, 2023 13:33

dotnet-issue-labeler bot added the area-Debugger-mono label Jan 25, 2023

ghost assigned thaystg Jan 25, 2023

radical added the arch-wasm WebAssembly architecture label Jan 25, 2023

radekdoulik approved these changes Jan 25, 2023

View reviewed changes

build-analysis bot mentioned this pull request Jan 25, 2023

Roslyn source generator crash on mono/linux/arm64 #81123

Closed

thaystg marked this pull request as draft January 25, 2023 17:41

thaystg added 2 commits January 30, 2023 15:20

Merge branch 'dotnet:main' into thays_fix_symbolServer_CI

2b3a815

Adding test case for it as discussed with @radical offline.

a3ea540

thaystg marked this pull request as ready for review January 31, 2023 16:25

thaystg requested a review from radical as a code owner January 31, 2023 16:25

radical reviewed Jan 31, 2023

View reviewed changes

Creating new tests and fixing its behavior.

5ee12e0

Merge branch 'dotnet:main' into thays_fix_symbolServer_CI

51ca956

This was referenced Feb 2, 2023

Tracking issue for CI build timeouts #76454

Closed

arm64 linux build machines seem to be missing key components? dotnet/arcade#12395

Closed

thaystg requested a review from ilonatommy February 2, 2023 15:35

ilonatommy reviewed Feb 2, 2023

View reviewed changes

src/mono/mono/component/debugger-agent.c Show resolved Hide resolved

Merge branch 'dotnet:main' into thays_fix_symbolServer_CI

13cf5f9

thaystg added 2 commits February 2, 2023 18:44

Addressing @radical comments offline.

35062da

Merge branch 'thays_fix_symbolServer_CI' of github.com:thaystg/runtim…

b4371c8

…e into thays_fix_symbolServer_CI

ilonatommy approved these changes Feb 3, 2023

View reviewed changes

same behavior for stepping, disable global_stepping while evaluating …

c735309

…expression.

radical reviewed Feb 6, 2023

View reviewed changes

src/mono/mono/component/debugger-agent.c Outdated Show resolved Hide resolved

Renaming function as suggested by @radical

ea3796e

Merge branch 'dotnet:main' into thays_fix_symbolServer_CI

e7f1ccb

radical approved these changes Feb 7, 2023

View reviewed changes

thaystg merged commit e3af787 into dotnet:main Feb 7, 2023

ghost locked as resolved and limited conversation to collaborators Mar 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wasm][debug] Avoid pausing on breakpoint while invoking methods. #81162

[wasm][debug] Avoid pausing on breakpoint while invoking methods. #81162

thaystg commented Jan 25, 2023 •

edited by radical

Loading

ghost commented Jan 25, 2023

ghost commented Jan 25, 2023

thaystg commented Jan 31, 2023

azure-pipelines bot commented Jan 31, 2023

radical Jan 31, 2023

thaystg Jan 31, 2023

radical Jan 31, 2023

thaystg Jan 31, 2023

radical Jan 31, 2023

thaystg commented Feb 1, 2023

azure-pipelines bot commented Feb 1, 2023

radical commented Feb 1, 2023

azure-pipelines bot commented Feb 1, 2023

thaystg commented Feb 2, 2023

azure-pipelines bot commented Feb 2, 2023

thaystg commented Feb 2, 2023

azure-pipelines bot commented Feb 2, 2023

thaystg commented Feb 5, 2023

azure-pipelines bot commented Feb 5, 2023

thaystg commented Feb 6, 2023

azure-pipelines bot commented Feb 6, 2023

radical left a comment

thaystg commented Feb 7, 2023

[wasm][debug] Avoid pausing on breakpoint while invoking methods. #81162

[wasm][debug] Avoid pausing on breakpoint while invoking methods. #81162

Conversation

thaystg commented Jan 25, 2023 • edited by radical Loading

ghost commented Jan 25, 2023

ghost commented Jan 25, 2023

thaystg commented Jan 31, 2023

azure-pipelines bot commented Jan 31, 2023

radical Jan 31, 2023

Choose a reason for hiding this comment

thaystg Jan 31, 2023

Choose a reason for hiding this comment

radical Jan 31, 2023

Choose a reason for hiding this comment

thaystg Jan 31, 2023

Choose a reason for hiding this comment

radical Jan 31, 2023

Choose a reason for hiding this comment

thaystg commented Feb 1, 2023

azure-pipelines bot commented Feb 1, 2023

radical commented Feb 1, 2023

azure-pipelines bot commented Feb 1, 2023

thaystg commented Feb 2, 2023

azure-pipelines bot commented Feb 2, 2023

thaystg commented Feb 2, 2023

azure-pipelines bot commented Feb 2, 2023

thaystg commented Feb 5, 2023

azure-pipelines bot commented Feb 5, 2023

thaystg commented Feb 6, 2023

azure-pipelines bot commented Feb 6, 2023

radical left a comment

Choose a reason for hiding this comment

thaystg commented Feb 7, 2023

thaystg commented Jan 25, 2023 •

edited by radical

Loading