Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] PGO AOT samples #81221

Closed
wants to merge 4 commits into from

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jan 26, 2023

  • I created AOT profile for Wasm.Advanced.Sample and Wasm.Browser.Bench.Sample to prove it works.
  • improved AOT logging
  • fixed how AotProfilePath is used for WASM

@radekdoulik I guess that the impact to the bechmark would be that the AOT size is smaller.
Could you please measure size and time difference on your machine ? We could roll it back from the benchmark afterwards and keep only the advanced sample, for which it's not so critical that we keep updating the .aotprofile file.

Contributes to #76316

@ghost
Copy link

ghost commented Jan 26, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • I created AOT profile for Wasm.Advanced.Sample and Wasm.Browser.Bench.Sample to prove it works.
  • I did small refactoring of bechmark yieldBench method to make it more readable for me.

@radekdoulik I guess that the impact to the bechmark would be that the AOT size is smaller.
Could you please measure size and time difference on your machine ? We could roll it back from the benchmark afterwards and keep only the advanced sample, for which it's not so critical that we keep updating the .aotprofile file.

Contributes to #76316

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone: 8.0.0

radekdoulik added a commit to radekdoulik/WasmPerformanceMeasurements that referenced this pull request Jan 27, 2023
…17:21:22 2023 +0100

This is from Pavel's dotnet/runtime#81221 and is temporary
# Conflicts:
#	src/mono/sample/wasm/browser-bench/Wasm.Browser.Bench.Sample.csproj
#	src/mono/sample/wasm/browser-bench/main.js
@ghost ghost closed this Mar 4, 2023
@ghost
Copy link

ghost commented Mar 4, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2023
@pavelsavara pavelsavara deleted the browser_pgo_samples branch September 2, 2024 15:29
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant