Disable function pointer test for crossgen due to an existing issue #81286
Conversation
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@steveisok @jkoritzinsky - is this the best way to disable test for outerloop runs. The context is a newly added test for Mono changes has uncovered a coreclr-outerloop run failure. We want to make sure 1. main outloop runs start passing again and 2. also backport this fix (to disable the test) to 7.0 servicing so CI stays clean there too |
|
Fan's intent was to decouple this particular test and its port from the Crossgen2 issue I'm reviewing a fix for in but the review is somewhat complicated due to requiring additional feedback (cf. the PR for more detail). Our current plan is that I'll remove the issues.targets exclusion as part of backporting my fix to .NET 7. |
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4032400280 |
|
@fanyang-mono backporting to release/7.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Disable function pointer test for crossgen due to a bug
Using index info to reconstruct a base tree...
M src/tests/issues.targets
Falling back to patching base and 3-way merge...
Auto-merging src/tests/issues.targets
CONFLICT (content): Merge conflict in src/tests/issues.targets
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Disable function pointer test for crossgen due to a bug
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@fanyang-mono an error occurred while backporting to release/7.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
|
Manually added the change here to the backport PR (#80927) |
ghost
locked as resolved and limited conversation to collaborators
Disable test due to an existing bug of crossgen2 (#81106)
This will allow my backported PR (#80927) being merged sooner.