[release/7.0][wasm] Fix the net7.0 build when only net6.0 workloads are installed #81390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emsdk turns that into requiring the workload
lewing
force-pushed
the
net6-triggering-net7
branch
from
3524d24 to
88ae49e
Compare
lewing
changed the title
lewing
changed the title
|
Tell mode @lewing ? |
radical
approved these changes
Feb 9, 2023
yes |
|
Great. CI failure is #81544. Merging now. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue found by internal testing when building using a net7.0.xx sdk with only the wasm-tools-net6 workload installed.
fix for https://github.com/aspnet/AspNetCore-ManualTests/issues/1722#issuecomment-1407320124
Customer Impact
Fixes a scenario where the customer has installed the wasm-tools-net6 but has not installed wasm-tools on a net7 sdk and gets an error requiring the net7 workload when it is not strictly required
Testing
Manual, this is difficult/impossible to test in CI on release branches with stable branding due to downlevel version mismatch.
Risk
Low.