-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider method accessibility in interface resolution #81409
Conversation
Fixes dotnet/corert#1986 (yep, all the way to CoreRT repo). We finally found an instance where this matters - in MAUI. Non-public methods never implement an interface by name+sig combo. We got the `ProtectedDerived` case in the newly added test wrong.
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
src/coreclr/tools/Common/TypeSystem/Common/MetadataVirtualMethodAlgorithm.cs
Outdated
Show resolved
Hide resolved
I'll need to clean up the failures in the extra-platform runs. Looks like there's extra fallout from #80896. There were many failures in the extra-platform run of that PR because those runs were broken by the previous dataflow changes (e.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=150101&view=logs&jobId=f50bdeb8-70f9-5fe0-0c12-4bd43ab59b51&j=f50bdeb8-70f9-5fe0-0c12-4bd43ab59b51&t=3941b02a-393b-543b-8813-9a3e5bea473a). I did not see the failures that are showing up in this run in that log. But now that I look at the previous log, it ends with:
and that's a suspiciously round number. It's possible Helix is just giving up once it reaches 100 failures? That's annoying. We need to start running extra-platforms on all NativeAOT changes to prevent ending up in this state again. |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Fixes dotnet/corert#1986 (yep, all the way to CoreRT repo).
We finally found an instance where this matters - in MAUI. Non-public methods never implement an interface by name+sig combo. We were getting the
ProtectedDerived
case in the newly added test wrong.Cc @dotnet/ilc-contrib
Cc @ivanpovazan