[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only
#81454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue Detailsnull
|
TIHan
changed the title
TIHan
changed the title
TIHan
force-pushed
the
fold-gt-lcl-var-addr
branch
from
3c27c57
to
af037ec
Compare
5 tasks
TIHan
changed the title
GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small types
TIHan
changed the title
GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small typesGT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types
TIHan
changed the title
GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesGT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types
TIHan
changed the title
GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesGT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types
drieseng
reviewed
Feb 4, 2023
TIHan
changed the title
GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesGT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only
2 tasks
|
@dotnet/jit-contrib cc @jakobbotsch There are a lot of ARM32 regressions, but this is due to the CSE rules for that target. |
Can you show some examples? What are/aren't we CSE'ing that changed from before? |
|
@jakobbotsch diff dump of one of the ARM32 regressions |
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
|
@SingleAccretion Ok, looks like I was seeing things before - allowed looking at long types for 32bit and there are quite a bit of improvements. |
jakobbotsch
approved these changes
Feb 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Will resolve: #55064
There are cases where
IND{short}(LCL_VAR_ADDR{int})can be transformed toCAST{int <- short <- int}(LCL_VAR{int})to prevent storing and reading from memory, but only if the indirection is narrow for integer types.This transformation will not occur for the storage of an assignment:
ASG(IND{short}(LCL_VAR_ADDR{int}}, ..).Acceptance Criteria