Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTTP/3] Add libnuma-dev into docker image #81764

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Feb 7, 2023

Attempt to fix #81706

cc: @antonfirsov

@ghost
Copy link

ghost commented Feb 7, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Attempt to fix #81706

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@ManickaP
Copy link
Member Author

ManickaP commented Feb 7, 2023

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@ManickaP
Copy link
Member Author

ManickaP commented Feb 7, 2023

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We may also try to fix msquic but that would certainly be much longer path.
And we already install bunch of -dev packages....

@ManickaP
Copy link
Member Author

ManickaP commented Feb 7, 2023

LGTM. We may also try to fix msquic but that would certainly be much longer path. And we already install bunch of -dev packages....

I can file an issue in msquic if you think we should pursue this. It doesn't have to be fixed right here right now as we have this fix.

@antonfirsov
Copy link
Member

It worked, so the fix is good enough for now. I'm also adding my +1 to make msquic packaging more stable, but can't comment on technical details there.

Thanks!

@antonfirsov antonfirsov merged commit 7ed86c7 into dotnet:main Feb 7, 2023
@antonfirsov antonfirsov added this to the 8.0.0 milestone Feb 7, 2023
@ManickaP ManickaP deleted the mapichov/stress branch February 8, 2023 09:55
@ghost ghost locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpStress fails to build msquic
4 participants