Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileStream and PipeStream code reuse for async File IO on Windows #81960

Closed
wants to merge 8 commits into from
Closed

FileStream and PipeStream code reuse for async File IO on Windows #81960

wants to merge 8 commits into from

Commits on Feb 10, 2023

  1. reverse the nesting of SafeFileHandle.OverlappedValueTaskSource

    @adamsitnik
    adamsitnik committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    ed96f09 View commit details
    Browse the repository at this point in the history

  2. make OverlappedValueTaskSource more generic so it could be reused by … 

    …SafePipeHandle
    @adamsitnik
    adamsitnik committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    e81f16a View commit details
    Browse the repository at this point in the history

  3. move some methods out of RandomAccess.Windows so they can be reused b… 

    …y Pipes
    @adamsitnik
    adamsitnik committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    27113c0 View commit details
    Browse the repository at this point in the history

  4. move the files to Common

    @adamsitnik
    adamsitnik committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    ffb0349 View commit details
    Browse the repository at this point in the history

  5. reuse the code in System.IO.Pipes

    @adamsitnik
    adamsitnik committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    ea2517a View commit details
    Browse the repository at this point in the history

  6. unify error handling for FileStream to behave exactly as it does for … 

    …PipeStream in case of pipes
    @adamsitnik
    adamsitnik committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    8a2cffc View commit details
    Browse the repository at this point in the history

  7. NamedPipeServerStream.WaitForConnectionAsync should throw OperationCa… 

    …nceledException when user obtains handle and calls CancelIoEx (this is what ReadAsync and WriteAsync do)
    @adamsitnik
    adamsitnik committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    e97db33 View commit details
    Browse the repository at this point in the history

  8. cleanup after reading the code again on GH

    @adamsitnik
    adamsitnik committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    e76bd6e View commit details
    Browse the repository at this point in the history