Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixing runtime-extra-platforms runs #82022

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

MichalStrehovsky
Copy link
Member

Runtime-extra-platforms are broken on Mac/Linux right now (see failures in #81747).

Looks like this was broken by #80382 that did run runtime-extra-platforms, but then made a change to this project file in 97dfa12 without rerunning the leg. I'm assuming this works on Windows.

cc @dotnet/ilc-contrib

@ghost
Copy link

ghost commented Feb 13, 2023

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Runtime-extra-platforms are broken on Mac/Linux right now (see failures in #81747).

Looks like this was broken by #80382 that did run runtime-extra-platforms, but then made a change to this project file in 97dfa12 without rerunning the leg. I'm assuming this works on Windows.

cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: MichalStrehovsky
Labels:

area-Extensions-Logging

Milestone: -

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Feb 13, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Runtime-extra-platforms are broken on Mac/Linux right now (see failures in #81747).

Looks like this was broken by #80382 that did run runtime-extra-platforms, but then made a change to this project file in 97dfa12 without rerunning the leg. I'm assuming this works on Windows.

cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: MichalStrehovsky
Labels:

area-NativeAOT-coreclr

Milestone: -

@MichalStrehovsky
Copy link
Member Author

cc @stephentoub - some Concurrent tests are still failing after #81957: https://helix.dot.net/api/2019-06-17/jobs/c087cc54-b07b-4112-bd05-e525345a1f11/workitems/System.Collections.Concurrent.Tests/console

Copy link
Member

@LakshanF LakshanF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichalStrehovsky MichalStrehovsky merged commit 86307e3 into main Feb 13, 2023
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-1 branch February 13, 2023 20:26
@MichalStrehovsky
Copy link
Member Author

@LakshanF looks like besides the Linux build break, there are also runtime failures on Windows in the Microsoft.Extensions.Logging.EventSource.Tests and System.Runtime.Caching.Tests.

I pulled down the dumps from this CI run (https://dev.azure.com/dnceng-public/public/_build/results?buildId=170238&view=ms.vss-test-web.build-test-results-tab&runId=3419779&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab&resultId=168001)

In both cases, we're running into a debugbreak (in disabledevenpipeinternal.cpp):

0000001a`0eafe340 00007ff7`0a9b3ef2     ntdll!KiUserExceptionDispatcher+0x2e
0b 0000001a`0eafea58 00007ff7`0aca606e     System_Runtime_Caching_Tests!RhEventPipeInternal_WaitForSessionSignal+0x2 [D:\a\_work\1\s\src\coreclr\nativeaot\Runtime\disabledeventpipeinternal.cpp @ 26] 
0c 0000001a`0eafea60 00007ff7`0aca687c     System_Runtime_Caching_Tests!S_P_CoreLib_System_Diagnostics_Tracing_EventPipeEventDispatcher___ctor+0x8e [/_/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventPipeEventDispatcher.cs @ 44] 
0d 0000001a`0eafeb00 00007ff7`0ace2934     System_Runtime_Caching_Tests!S_P_CoreLib_System_Diagnostics_Tracing_EventPipeEventDispatcher___cctor+0x1c [/_/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventPipeEventDispatcher.cs @ 25] 
0e 0000001a`0eafeb30 00007ff7`0ace280d     System_Runtime_Caching_Tests!S_P_CoreLib_System_Runtime_CompilerServices_ClassConstructorRunner__EnsureClassConstructorRun+0xc4 [/_/src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/CompilerServices/ClassConstructorRunner.cs @ 88] 
0f 0000001a`0eafebc0 00007ff7`0acb61ed     System_Runtime_Caching_Tests!S_P_CoreLib_System_Runtime_CompilerServices_ClassConstructorRunner__CheckStaticClassConstructionReturnGCStaticBase+0xd [/_/src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/CompilerServices/ClassConstructorRunner.cs @ 36] 
10 0000001a`0eafebf0 00007ff7`0acb59be     System_Runtime_Caching_Tests!S_P_CoreLib_System_Diagnostics_Tracing_EventListener__RemoveReferencesToListenerInEventSources+0x14d [/_/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs @ 4275] 
11 0000001a`0eafec50 00007ff7`0ae9b095     System_Runtime_Caching_Tests!S_P_CoreLib_System_Diagnostics_Tracing_EventListener__Dispose+0x5e [/_/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs @ 3988] 
12 0000001a`0eafecb0 00007ff7`0a941e66     System_Runtime_Caching_Tests!System_Runtime_Caching_Tests_MonoTests_System_Runtime_Caching_CountersTest__PollCounters_d__1__MoveNext+0x615 [/_/src/libraries/System.Runtime.Caching/tests/System.Runtime.Caching/CountersTest.cs @ 135] 
13 0000001a`0eafed10 00007ff7`0acdd5bf     System_Runtime_Caching_Tests!RhpCallFinallyFunclet+0x136 [D:\a\_work\1\s\src\coreclr\nativeaot\Runtime\amd64\ExceptionHandling.asm @ 606] 
14 0000001a`0eafee20 00007ff7`0acdd2ab     System_Runtime_Caching_Tests!S_P_CoreLib_System_Runtime_EH__InvokeSecondPass_0+0xbf [/_/src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs @ 969] 
15 0000001a`0eafeee0 00007ff7`0acdcfa1     System_Runtime_Caching_Tests!S_P_CoreLib_System_Runtime_EH__DispatchEx+0x2ab [/_/src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs @ 748] 
16 0000001a`0eafef80 00007ff7`0a9419a7     System_Runtime_Caching_Tests!S_P_CoreLib_System_Runtime_EH__RhThrowEx+0x51 [/_/src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs @ 573] 
17 0000001a`0eafefc0 00007ff7`0ace1bc0     System_Runtime_Caching_Tests!RhpThrowEx+0x117 [D:\a\_work\1\s\src\coreclr\nativeaot\Runtime\amd64\ExceptionHandling.asm @ 190] 
18 0000001a`0eaff360 00007ff7`0ace47d5     System_Runtime_Caching_Tests!S_P_CoreLib_System_Runtime_ExceptionServices_ExceptionDispatchInfo__Throw+0x20 [/_/src/libraries/System.Private.CoreLib/src/System/Runtime/ExceptionServices/ExceptionDispatchInfo.cs @ 53] 
19 0000001a`0eaff390 00007ff7`0ace4709     System_Runtime_Caching_Tests!S_P_CoreLib_System_Runtime_CompilerServices_TaskAwaiter__ThrowForNonSuccess+0xc5 [/_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs @ 180] 
1a 0000001a`0eaff3d0 00007ff7`0ae9ac5d     System_Runtime_Caching_Tests!S_P_CoreLib_System_Runtime_CompilerServices_TaskAwaiter__HandleNonSuccessAndDebuggerNotification+0x59 [/_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs @ 149] 
1b 0000001a`0eaff400 00007ff7`0ac756f7     System_Runtime_Caching_Tests!System_Runtime_Caching_Tests_MonoTests_System_Runtime_Caching_CountersTest__PollCounters_d__1__MoveNext+0x1dd [/_/src/libraries/System.Runtime.Caching/tests/System.Runtime.Caching/CountersTest.cs @ 82] 
1c 0000001a`0eaff4d0 00007ff7`0b18d255     System_Runtime_Caching_Tests!S_P_CoreLib_System_Threading_ExecutionContext__RunInternal+0x87 [/_/src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs @ 183] 
1d 0000001a`0eaff540 00007ff7`0aba2c33     System_Runtime_Caching_Tests!S_P_CoreLib_System_Runtime_CompilerServices_AsyncTaskMethodBuilder_1_AsyncStateMachineBox_1<System_Runtime_Caching_Tests_MonoTests_System_Runtime_Caching_MemoryCacheCounterValues__System_Runtime_Caching_Tests_MonoTests_System_Runtime_Caching_CountersTest__PollCounters_d__1>__MoveNext_0+0x95 [/_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncTaskMethodBuilderT.cs @ 324] 
1e 0000001a`0eaff5a0 00007ff7`0ab95c21     System_Runtime_Caching_Tests!xunit_execution_dotnet_Xunit_Sdk_AsyncTestSyncContext___c__DisplayClass7_0___Post_b__1+0x23 [/_/src/xunit.execution/Sdk/AsyncTestSyncContext.cs @ 75] 
1f 0000001a`0eaff5e0 00007ff7`0ac756f7     System_Runtime_Caching_Tests!xunit_execution_dotnet_Xunit_Sdk_MaxConcurrencySyncContext__RunOnSyncContext+0x51 [/_/src/xunit.execution/Sdk/MaxConcurrencySyncContext.cs @ 107] 
20 0000001a`0eaff630 00007ff7`0b37ad35     System_Runtime_Caching_Tests!S_P_CoreLib_System_Threading_ExecutionContext__RunInternal+0x87 [/_/src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs @ 183] 
21 0000001a`0eaff6a0 00007ff7`0ace9997     System_Runtime_Caching_Tests!Internal_CompilerGenerated__Module___<DynamicInvoke>Static<S_P_CoreLib_System_Void__Object__Object__Object>+0x25
22 0000001a`0eaff6d0 00007ff7`0aed7ea9     System_Runtime_Caching_Tests!S_P_CoreLib_System_Reflection_DynamicInvokeInfo__Invoke+0x167 [/_/src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/DynamicInvokeInfo.cs @ 245] 
23 0000001a`0eaff7a0 00007ff7`0ad107d5     System_Runtime_Caching_Tests!S_P_Reflection_Execution_Internal_Reflection_Execution_MethodInvokers_StaticMethodInvoker__Invoke+0x29 [/_/src/coreclr/nativeaot/System.Private.Reflection.Execution/src/Internal/Reflection/Execution/MethodInvokers/StaticMethodInvoker.cs @ 36] 

@tarekgh
Copy link
Member

tarekgh commented Feb 14, 2023

@LakshanF could you please track fixing this with some issue? Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants