Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0] Update WASM Windows helix queue #82097

Merged
merged 1 commit into from
Feb 14, 2023
Merged

[6.0] Update WASM Windows helix queue #82097

merged 1 commit into from
Feb 14, 2023

Conversation

carlossanlop
Copy link
Member

This backport PR hit failures in wasm due to the image not existing anymore: #82062

This fix matches the image we use in main: https://github.com/carlossanlop/runtime/blob/a6741d9c609cf402e319d67cc902cb574c15afa4/eng/pipelines/libraries/helix-queues-setup.yml#L200

@carlossanlop carlossanlop self-assigned this Feb 14, 2023
@ghost
Copy link

ghost commented Feb 14, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This backport PR hit failures in wasm due to the image not existing anymore: #82062

This fix matches the image we use in main: https://github.com/carlossanlop/runtime/blob/a6741d9c609cf402e319d67cc902cb574c15afa4/eng/pipelines/libraries/helix-queues-setup.yml#L200

Author: carlossanlop
Assignees: carlossanlop
Labels:

arch-wasm, area-Infrastructure-mono
Milestone: -

@ghost
Copy link

ghost commented Feb 14, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This backport PR hit failures in wasm due to the image not existing anymore: #82062

This fix matches the image we use in main: https://github.com/carlossanlop/runtime/blob/a6741d9c609cf402e319d67cc902cb574c15afa4/eng/pipelines/libraries/helix-queues-setup.yml#L200

Author: carlossanlop
Assignees: carlossanlop
Labels:

arch-wasm, area-Infrastructure-mono
Milestone: -

@carlossanlop carlossanlop mentioned this pull request Feb 14, 2023
Merged
radical
radical approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI passes, 👍

@carlossanlop
Copy link
Member Author

A green CI result in 6.0. Such a rare sight 🥹.

@carlossanlop carlossanlop merged commit b03c426 into dotnet:release/6.0 Feb 14, 2023
@carlossanlop carlossanlop deleted the updateWasmQueue branch February 14, 2023 19:04
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveisok steveisok steveisok approved these changes

@radical radical radical approved these changes

@lewing lewing Awaiting requested review from lewing

@lambdageek lambdageek Awaiting requested review from lambdageek

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees

@carlossanlop carlossanlop

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossanlop @radical @steveisok