Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0] Update dependencies from dotnet/emsdk #82192

Merged
merged 11 commits into from
Mar 13, 2023
Merged

[release/7.0] Update dependencies from dotnet/emsdk #82192

merged 11 commits into from
Mar 13, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Feb 15, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/emsdk

  • Subscription: 68df92bc-29da-47e1-6f60-08da7ef6374d
  • Build: 20230309.4
  • Date Produced: March 10, 2023 3:35:46 AM UTC
  • Commit: 3d7178d836ea32bb7bb51d8d1c714d52fe641ffa
  • Branch: refs/heads/release/7.0

@dotnet-maestro
Update dependencies from https://github.com/dotnet/emsdk build 202302…
d5b8698 
…15.1

Microsoft.NET.Workload.Emscripten.net6.Manifest-7.0.100 , Microsoft.NET.Workload.Emscripten.net7.Manifest-7.0.100
 From Version 7.0.4 -> To Version 7.0.4
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Feb 15, 2023
@lewing
Copy link
Member

lewing commented Feb 17, 2023

failure is #82271

@build-analysis build-analysis bot mentioned this pull request Feb 18, 2023
Closed
@runfoapp runfoapp bot mentioned this pull request Feb 20, 2023
Closed
@lewing lewing closed this Feb 27, 2023
@lewing lewing reopened this Feb 27, 2023
@build-analysis build-analysis bot mentioned this pull request Feb 27, 2023
Closed
@lewing lewing closed this Mar 4, 2023
@lewing lewing reopened this Mar 4, 2023
@build-analysis build-analysis bot mentioned this pull request Mar 5, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Mar 8, 2023
Closed
@carlossanlop
Copy link
Member

@lewing / @steveisok / @radical - Can one of you please help resolve the merge conflict?

@build-analysis build-analysis bot mentioned this pull request Mar 9, 2023
Closed
@carlossanlop
Copy link
Member

@lewing do you think the failures are related to branding?

eng\testing\workloads-testing.targets(218,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Verifying Microsoft.NET.Runtime.WebAssembly.Sdk.7.0.5

eng\testing\workloads-testing.targets(218,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) error: NU3004: The package is not signed.

eng\testing\workloads-testing.targets(218,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Workload installation failed: Failed to validate package signing.

@lewing
Copy link
Member

lewing commented Mar 9, 2023

@lewing do you think the failures are related to branding?

eng\testing\workloads-testing.targets(218,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Verifying Microsoft.NET.Runtime.WebAssembly.Sdk.7.0.5

eng\testing\workloads-testing.targets(218,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) error: NU3004: The package is not signed.

eng\testing\workloads-testing.targets(218,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Workload installation failed: Failed to validate package signing.

my guess it it because we got rate limited on signing https://dev.azure.com/dnceng/internal/_build/results?buildId=2130614&view=results

cc @steveisok

@lewing
Copy link
Member

lewing commented Mar 9, 2023

Or maybe not, @joeloff is there some reaction we need to make in net7 for signing still?

@joeloff
Copy link
Member

joeloff commented Mar 9, 2023

I'm not aware of anything. As long as packages are designated as shipping, signing should just be automatic AFAIK.

@build-analysis build-analysis bot mentioned this pull request Mar 10, 2023
Closed
dotnet-maestro bot and others added 2 commits March 10, 2023 04:05
@dotnet-maestro
Update dependencies from https://github.com/dotnet/emsdk build 202303…
4eef6ac 
…09.4

Microsoft.NET.Workload.Emscripten.net6.Manifest-7.0.100 , Microsoft.NET.Workload.Emscripten.net7.Manifest-7.0.100
 From Version 7.0.4 -> To Version 7.0.4
@lewing
Merge branch 'release/7.0' into darc-release/7.0-ff541f0b-d64f-47f7-a…
2457c1e 
…eb7-ed4609c35e59
@lewing
Copy link
Member

lewing commented Mar 10, 2023

I'm pretty sure the issue now is that the sdk we construct for WasmBuildTests is failing on the unsigned packages @steveisok can you take a look.

@steveisok steveisok requested a review from radical as a code owner March 13, 2023 15:00
@steveisok steveisok self-requested a review March 13, 2023 20:54
@carlossanlop carlossanlop merged commit 2a0783a into release/7.0 Mar 13, 2023
@carlossanlop carlossanlop deleted the darc-release/7.0-ff541f0b-d64f-47f7-aeb7-ed4609c35e59 branch March 13, 2023 23:59
@ghost ghost locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@radical radical Awaiting requested review from radical radical is a code owner

@steveisok steveisok Awaiting requested review from steveisok

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewing @carlossanlop @joeloff